Fix calls of strict mode function with an implicit receiver.

src/v8globals.h

Index: src/v8globals.h
diff --git a/src/v8globals.h b/src/v8globals.h
index 1f34d97bc3735979906ccf1e1904f0d9e52abbb2..3e2453edf9ef74423cb01b75986e1a0e5cb5ce0f 100644
--- a/src/v8globals.h
+++ b/src/v8globals.h
@@ -310,7 +310,10 @@ enum InLoopFlag {
 
 enum CallFunctionFlags {
   NO_CALL_FUNCTION_FLAGS = 0,
-  RECEIVER_MIGHT_BE_VALUE = 1 << 0  // Receiver might not be a JSObject.
+  // Receiver might not be a JSObject.
+  RECEIVER_MIGHT_BE_VALUE = 1 << 0,
+  // Receiver is a non-value but might be implicit.

[Kevin Millikin (Chromium), 2011/05/18 15:57:23]

As it is, these are used as if mutually exclusive, not mix and match bits. 
That's a little confusing.  I think they should be used as separate bits even if
01 doesn't make sense.

I think "Receiver is a JSObject but might be implicit." is clearer.  You could
shorten the name to RECEIVER_MIGHT_BE_IMPLICIT if you want.  Maybe even better:
CHECK_IF_RECEIVER_IS_VALUE and CHECK_IF_RECEIVER_IS_IMPLICIT.

Even more radical is to move this enum into CallFunctionStub and just do
something like:

class CallFunctionStub {
  ...
  enum ReceiverCheck { NONE, VALUE = 0x1, IMPLICIT = 0x2 };

+  NON_VALUE_RECEIVER_MIGHT_BE_IMPLICIT = 1 << 1
 };
 
 
@@ -497,6 +500,14 @@ enum SmiCheckType {
   DO_SMI_CHECK
 };
 
+
+// Used to specify whether a receiver is implicitly or explicitly
+// provided to a call.
+enum ReceiverType {

[Kevin Millikin (Chromium), 2011/05/18 15:57:23]

Maybe this is not quite the right name.  There is no explicit receiver in with
(...) { ... f() ... }.  Maybe it's better to put the focus on the kind of call:

enum CallKind { CALL_AS_METHOD, CALL_AS_FUNCTION }?

[Mads Ager (chromium), 2011/05/23 16:31:34]

I agree. Your suggestion is better. Done.

+  EXPLICIT_RECEIVER = 0,
+  IMPLICIT_RECEIVER
+};
+
 } }  // namespace v8::internal
 
 #endif  // V8_V8GLOBALS_H_