Fix calls of strict mode function with an implicit receiver.

src/v8globals.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 292 matching lines @@
 
 
 enum InLoopFlag {
   NOT_IN_LOOP,
   IN_LOOP
 };
 
 
 enum CallFunctionFlags {
   NO_CALL_FUNCTION_FLAGS = 0,
-  RECEIVER_MIGHT_BE_VALUE = 1 << 0  // Receiver might not be a JSObject.
+  // Receiver might not be a JSObject.
+  RECEIVER_MIGHT_BE_VALUE = 1 << 0,
+  // Receiver is a non-value but might be implicit.

[Kevin Millikin (Chromium), 2011/05/18 15:57:23]

As it is, these are used as if mutually exclusive, not mix and match bits. 
That's a little confusing.  I think they should be used as separate bits even if
01 doesn't make sense.

I think "Receiver is a JSObject but might be implicit." is clearer.  You could
shorten the name to RECEIVER_MIGHT_BE_IMPLICIT if you want.  Maybe even better:
CHECK_IF_RECEIVER_IS_VALUE and CHECK_IF_RECEIVER_IS_IMPLICIT.

Even more radical is to move this enum into CallFunctionStub and just do
something like:

class CallFunctionStub {
  ...
  enum ReceiverCheck { NONE, VALUE = 0x1, IMPLICIT = 0x2 };

+  NON_VALUE_RECEIVER_MIGHT_BE_IMPLICIT = 1 << 1
 };
 
 
 enum InlineCacheHolderFlag {
   OWN_MAP,  // For fast properties objects.
   PROTOTYPE_MAP  // For slow properties objects (except GlobalObjects).
 };
 
 
 // Type of properties.
@@ skipping 166 matching lines @@
 };
 
 
 // Used to specify if a macro instruction must perform a smi check on tagged
 // values.
 enum SmiCheckType {
   DONT_DO_SMI_CHECK = 0,
   DO_SMI_CHECK
 };
 
+
+// Used to specify whether a receiver is implicitly or explicitly
+// provided to a call.
+enum ReceiverType {

[Kevin Millikin (Chromium), 2011/05/18 15:57:23]

Maybe this is not quite the right name.  There is no explicit receiver in with
(...) { ... f() ... }.  Maybe it's better to put the focus on the kind of call:

enum CallKind { CALL_AS_METHOD, CALL_AS_FUNCTION }?

[Mads Ager (chromium), 2011/05/23 16:31:34]

I agree. Your suggestion is better. Done.

+  EXPLICIT_RECEIVER = 0,
+  IMPLICIT_RECEIVER
+};
+
 } }  // namespace v8::internal
 
 #endif  // V8_V8GLOBALS_H_