Extension in background unable to open window if there is no browser running.

Extension in background unable to open window if there is no browser running.

modified:   chrome/browser/extensions/extension_host.cc

BUG=83150
TEST=Have an extension with a background page running.  Close all browsers.
Open a window from the extension.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85950

[prasadt, 2011-05-19 00:48:31]

This seems to be a recent regression.  If you have thoughts on how this could be
tested, I can add a test.  Thanks.

[Matt Perry, 2011-05-19 00:50:32]

LGTM

http://codereview.chromium.org/7037040/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_host.cc (right):

http://codereview.chromium.org/7037040/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_host.cc:601: if (!browser)
Does it make sense to set the profile even if browser is non-NULL?

[prasadt, 2011-05-19 00:58:18]

http://codereview.chromium.org/7037040/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_host.cc (right):

http://codereview.chromium.org/7037040/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_host.cc:601: if (!browser)
On 2011/05/19 00:50:32, Matt Perry wrote:
> Does it make sense to set the profile even if browser is non-NULL?

I'm not really sure and tried to make the fix affecting as little as possible. 
Current code is using the browser's profile if there is a browser instance.

[Matt Perry, 2011-05-19 01:01:32]

http://codereview.chromium.org/7037040/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_host.cc (right):

http://codereview.chromium.org/7037040/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_host.cc:601: if (!browser)
On 2011/05/19 00:58:18, prasadt wrote:
> On 2011/05/19 00:50:32, Matt Perry wrote:
> > Does it make sense to set the profile even if browser is non-NULL?
> 
> I'm not really sure and tried to make the fix affecting as little as possible.

> Current code is using the browser's profile if there is a browser instance.

Fair enough.