Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: chrome/browser/extensions/extension_host.cc

Issue 7037040: Extension in background unable to open window if there is no browser running. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_host.cc
diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc
index 7badebfca008cb1df3d75ec7525b169c527e6843..160931716937d40f8625fc0254ec9237c99726ed 100644
--- a/chrome/browser/extensions/extension_host.cc
+++ b/chrome/browser/extensions/extension_host.cc
@@ -598,6 +598,8 @@ void ExtensionHost::ShowCreatedWindow(int route_id,
false); // Match incognito exactly.
TabContentsWrapper* wrapper = new TabContentsWrapper(contents);
browser::NavigateParams params(browser, wrapper);
+ if (!browser)
Matt Perry 2011/05/19 00:50:32 Does it make sense to set the profile even if brow
prasadt 2011/05/19 00:58:18 I'm not really sure and tried to make the fix affe
Matt Perry 2011/05/19 01:01:32 Fair enough.
+ params.profile = contents->profile();
params.disposition = NEW_POPUP;
params.window_bounds = initial_pos;
params.window_action = browser::NavigateParams::SHOW_WINDOW;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698