Write installer results in all relevant registry keys so that we're sure that Google Update will ...

Write installer results in all relevant registry keys so that we're sure that Google Update will pick them up regardless of which one it happens to be monitoring.

BUG=none
TEST=Google Update continues to properly report install errors to its servers.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85921

[robertshield, 2011-05-18 12:28:40]

lg, nits:

http://codereview.chromium.org/7036017/diff/7004/chrome/installer/mini_instal...
File chrome/installer/mini_installer/mini_installer.cc (right):

http://codereview.chromium.org/7036017/diff/7004/chrome/installer/mini_instal...
chrome/installer/mini_installer/mini_installer.cc:307: 
Remove extra blank line.

http://codereview.chromium.org/7036017/diff/7004/chrome/installer/util/instal...
File chrome/installer/util/install_util.h (right):

http://codereview.chromium.org/7036017/diff/7004/chrome/installer/util/instal...
chrome/installer/util/install_util.h:54: // for more details.
I wonder if we should enforce that install_list is a NoRollbackWorkItemList
here..

http://codereview.chromium.org/7036017/diff/7004/chrome/installer/util/instal...
File chrome/installer/util/installer_state_unittest.cc (right):

http://codereview.chromium.org/7036017/diff/7004/chrome/installer/util/instal...
chrome/installer/util/installer_state_unittest.cc:420:
TempRegKeyOverride::DeleteAllTempKeys();
should also test the error field and the UI string really.

[grt (UTC plus 2), 2011-05-18 13:39:30]

Thanks for the comments.  PTAL.

http://codereview.chromium.org/7036017/diff/7004/chrome/installer/mini_instal...
File chrome/installer/mini_installer/mini_installer.cc (right):

http://codereview.chromium.org/7036017/diff/7004/chrome/installer/mini_instal...
chrome/installer/mini_installer/mini_installer.cc:307: 
On 2011/05/18 12:28:40, robertshield wrote:
> Remove extra blank line.

Done.

http://codereview.chromium.org/7036017/diff/7004/chrome/installer/util/instal...
File chrome/installer/util/install_util.h (right):

http://codereview.chromium.org/7036017/diff/7004/chrome/installer/util/instal...
chrome/installer/util/install_util.h:54: // for more details.
On 2011/05/18 12:28:40, robertshield wrote:
> I wonder if we should enforce that install_list is a NoRollbackWorkItemList
> here..

I've added a comment recommending this.  (We have no mechanism to enforce it
short of RTTI.)

http://codereview.chromium.org/7036017/diff/7004/chrome/installer/util/instal...
File chrome/installer/util/installer_state_unittest.cc (right):

http://codereview.chromium.org/7036017/diff/7004/chrome/installer/util/instal...
chrome/installer/util/installer_state_unittest.cc:420:
TempRegKeyOverride::DeleteAllTempKeys();
On 2011/05/18 12:28:40, robertshield wrote:
> should also test the error field and the UI string really.

Done.

[grt (UTC plus 2), 2011-05-19 13:15:41]

ping

[robertshield, 2011-05-19 13:45:43]

On 2011/05/19 13:15:41, grt wrote:
> ping

LGTM

[commit-bot: I haz the power, 2011-05-19 16:20:20]

Change committed as 85921