Write installer results in all relevant registry keys so that we're sure that Google Update will ...

chrome/installer/mini_installer/mini_installer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // mini_installer.exe is the first exe that is run when chrome is being
 // installed or upgraded. It is designed to be extremely small (~5KB with no
 // extra resources linked) and it has two main jobs:
 //   1) unpack the resources (possibly decompressing some)
 //   2) run the real installer (setup.exe) with appropriate flags.
 //
@@ skipping 286 matching lines @@
     if (!::GetExitCodeProcess(pi.hProcess,
                               reinterpret_cast<DWORD*>(exit_code))) {
       ret = false;
     }
   }
 
   ::CloseHandle(pi.hProcess);
 
   return ret;
 }
 

[robertshield, 2011/05/18 12:28:40]

Remove extra blank line.

[grt (UTC plus 2), 2011/05/18 13:39:30]

Done.

 
+// Append any command line params passed to mini_installer to the given buffer
+// so that they can be passed on to setup.exe. We do not return any error from
+// this method and simply skip making any changes in case of error.
+void AppendCommandLineFlags(CommandString* buffer) {
+  PathString full_exe_path;
+  size_t len = ::GetModuleFileName(NULL, full_exe_path.get(),
+                                   full_exe_path.capacity());
+  if (!len || len >= full_exe_path.capacity())
+    return;
+
+  const wchar_t* exe_name = GetNameFromPathExt(full_exe_path.get(), len);
+  if (exe_name == NULL)
+    return;
+
+  int args_num;
+  wchar_t* cmd_line = ::GetCommandLine();
+  wchar_t** args = ::CommandLineToArgvW(cmd_line, &args_num);
+  if (args_num <= 0)
+    return;
+
+  const wchar_t* cmd_to_append = L"";
+  if (!StrEndsWith(args[0], exe_name)) {
+    // Current executable name not in the command line so just append
+    // the whole command line.
+    cmd_to_append = cmd_line;
+  } else if (args_num > 1) {
+    const wchar_t* tmp = SearchStringI(cmd_line, exe_name);
+    tmp = SearchStringI(tmp, L" ");
+    cmd_to_append = tmp;
+  }
+
+  buffer->append(cmd_to_append);
+
+  LocalFree(args);
+}
+
+
 // Windows defined callback used in the EnumResourceNames call. For each
 // matching resource found, the callback is invoked and at this point we write
 // it to disk. We expect resource names to start with 'chrome' or 'setup'. Any
 // other name is treated as an error.
 BOOL CALLBACK OnResourceFound(HMODULE module, const wchar_t* type,
                               wchar_t* name, LONG_PTR context) {
   if (NULL == context)
     return FALSE;
 
   Context* ctx = reinterpret_cast<Context*>(context);
@@ skipping 69 matching lines @@
         !cmd_line.append(L"=\"") ||
         !cmd_line.append(setup_path->get()) ||
         !cmd_line.append(L"\"") ||
         !cmd_line.append(kCmdNewSetupExe) ||
         !cmd_line.append(L"=\"") ||
         !cmd_line.append(setup_dest_path.get()) ||
         !cmd_line.append(L"\"")) {
       success = false;
     }
 
+    // Get any command line option specified for mini_installer and pass them
+    // on to setup.exe.  This is important since switches such as
+    // --multi-install and --chrome-frame affect where setup.exe will write
+    // installer results for consumption by Google Update.
+    AppendCommandLineFlags(&cmd_line);
+
     int exit_code = 0;
     if (success &&
         (!RunProcessAndWait(NULL, cmd_line.get(), &exit_code) ||
          exit_code != ERROR_SUCCESS)) {
       success = false;
     }
 
     if (!success)
       DeleteFile(setup_path->get());
 
@@ skipping 40 matching lines @@
         setup_path->clear();
       } else if (!setup_path->assign(setup_dest_path.get())) {
         ::DeleteFile(setup_dest_path.get());
       }
     }
   }
 
   return setup_path->length() > 0;
 }
 
-// Append any command line params passed to mini_installer to the given buffer
-// so that they can be passed on to setup.exe. We do not return any error from
-// this method and simply skip making any changes in case of error.
-void AppendCommandLineFlags(CommandString* buffer) {
-  PathString full_exe_path;
-  size_t len = ::GetModuleFileName(NULL, full_exe_path.get(),
-                                   full_exe_path.capacity());
-  if (!len || len >= full_exe_path.capacity())
-    return;
-
-  const wchar_t* exe_name = GetNameFromPathExt(full_exe_path.get(), len);
-  if (exe_name == NULL)
-    return;
-
-  int args_num;
-  wchar_t* cmd_line = ::GetCommandLine();
-  wchar_t** args = ::CommandLineToArgvW(cmd_line, &args_num);
-  if (args_num <= 0)
-    return;
-
-  const wchar_t* cmd_to_append = L"";
-  if (!StrEndsWith(args[0], exe_name)) {
-    // Current executable name not in the command line so just append
-    // the whole command line.
-    cmd_to_append = cmd_line;
-  } else if (args_num > 1) {
-    const wchar_t* tmp = SearchStringI(cmd_line, exe_name);
-    tmp = SearchStringI(tmp, L" ");
-    cmd_to_append = tmp;
-  }
-
-  buffer->append(cmd_to_append);
-
-  LocalFree(args);
-}
-
 // Executes setup.exe, waits for it to finish and returns the exit code.
 bool RunSetup(const wchar_t* archive_path, const wchar_t* setup_path,
               int* exit_code) {
   // There could be three full paths in the command line for setup.exe (path
   // to exe itself, path to archive and path to log file), so we declare
   // total size as three + one additional to hold command line options.
   CommandString cmd_line;
 
   // Get the path to setup.exe first.
   if (::lstrlen(setup_path) > 0) {
@@ skipping 339 matching lines @@
     case 1:
       dest8[count - 1] = c;
   }
 
   while (adjcount-- > 0)  // Copy the rest, 4 bytes/32 bits at a time
     *(dest32++) = fill;
 
   return dest;
 }
 }  // extern "C"