|
|
Consolidate ShouldUseNativeFrame/AlwaysUseNativeFrame/UseNativeFrame spaghetti.
Now there is:
... window::ShouldUseNativeFrame()
Which is basically just a pass-thru to
WindowWin::ShouldUseNativeFrame()
... which can be overridden by subclasses. Native-Frame is a windows-only concept but keeping the API on Window means I don't have to update a lot of call sites.
Window also gains a FrameType state member that toggles three states - default, force-native and force-custom.
This supercedes the "AlwaysUseNativeFrame/AlwaysUseCustomFrame" methods on NonClientView.
I have also hooked up a context menu item behind a command line flag --debug-enable-frame-toggle that allows the frame type for an individual window to be toggled, useful for debugging.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85666
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+130 lines, -153 lines) |
Patch |
 |
M |
chrome/app/chrome_command_ids.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/frame/browser_non_client_frame_view_factory_chromeos.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/external_tab_container_win.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/external_tab_container_win.cc
|
View
|
|
1 chunk |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/panels/panel_browser_frame_view.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/panels/panel_browser_frame_view.cc
|
View
|
|
3 chunks |
+1 line, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/constrained_window_views.cc
|
View
|
|
3 chunks |
+4 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/app_panel_browser_frame_view.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc
|
View
|
|
2 chunks |
+2 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_frame.h
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_frame.cc
|
View
|
|
2 chunks |
+1 line, -17 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_frame_win.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_frame_win.cc
|
View
|
|
4 chunks |
+21 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_gtk.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_view.h
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_view.cc
|
View
|
|
4 chunks |
+16 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/glass_browser_frame_view.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/glass_browser_frame_view.cc
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/opaque_browser_frame_view.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
|
View
|
|
1 chunk |
+0 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/popup_non_client_frame_view.h
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/popup_non_client_frame_view.cc
|
View
|
|
2 chunks |
+5 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/tabs/tab.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/tabs/tab_strip.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/toolbar_view.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/common/chrome_switches.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/chrome_switches.cc
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
views/widget/widget_win.cc
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
views/window/native_window_delegate.h
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
views/window/non_client_view.h
|
View
|
|
2 chunks |
+0 lines, -14 lines |
0 comments
|
Download
|
|
M |
views/window/non_client_view.cc
|
View
|
|
2 chunks |
+0 lines, -23 lines |
0 comments
|
Download
|
|
M |
views/window/window.h
|
View
|
|
4 chunks |
+17 lines, -1 line |
0 comments
|
Download
|
|
M |
views/window/window.cc
|
View
|
|
3 chunks |
+15 lines, -5 lines |
0 comments
|
Download
|
|
M |
views/window/window_win.cc
|
View
|
1
|
15 chunks |
+18 lines, -16 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
7036014:
Consolidate ShouldUseNativeFrame/AlwaysUseNativeFrame/UseNativeFrame spaghetti. (Closed)
