Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 7036014: Consolidate ShouldUseNativeFrame/AlwaysUseNativeFrame/UseNativeFrame spaghetti. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar_view.cc
===================================================================
--- chrome/browser/ui/views/toolbar_view.cc (revision 85647)
+++ chrome/browser/ui/views/toolbar_view.cc (working copy)
@@ -466,7 +466,7 @@
}
int vertical_spacing = PopupTopSpacing() +
- (GetWindow()->non_client_view()->UseNativeFrame() ?
+ (GetWindow()->ShouldUseNativeFrame() ?
kPopupBottomSpacingGlass : kPopupBottomSpacingNonGlass);
return gfx::Size(0, location_bar_->GetPreferredSize().height() +
vertical_spacing);
@@ -566,7 +566,7 @@
// it from the content area. For non-glass, the NonClientView draws the
// toolbar background below the location bar for us.
// NOTE: Keep this in sync with BrowserView::GetInfoBarSeparatorColor()!
- if (GetWindow()->non_client_view()->UseNativeFrame())
+ if (GetWindow()->ShouldUseNativeFrame())
canvas->FillRectInt(SK_ColorBLACK, 0, height() - 1, width(), 1);
}
@@ -646,7 +646,7 @@
// it's possible the crash may just show up somewhere else.
const views::Window* window = GetWindow();
DCHECK(window) << "If you hit this please talk to beng";
- return window && window->non_client_view()->UseNativeFrame() ?
+ return window && window->ShouldUseNativeFrame() ?
0 : kPopupTopSpacingNonGlass;
}
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698