Add hideKeyboard API to chrome.experimental.input.

Add hideKeyboard API to chrome.experimental.input.

And use the API in the keyboard.

BUG=chromium:76413
TEST=manually on chromebook

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86322

[mazda, 2011-05-19 22:04:11]

Could you take another look at the patch?

[mazda, 2011-05-19 22:05:04]

Could you take another look at the patch?

[bryeung, 2011-05-19 22:23:42]

http://codereview.chromium.org/7033033/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_function_dispatcher.cc (right):

http://codereview.chromium.org/7033033/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_function_dispatcher.cc:278: #if
defined(OS_CHROMEOS)
Is this suggested style?

I'd prefer we did not nest #ifs, and had separate TOUCH_UI && OS_CHROMEOS and
TOUCH_UI sections.

http://codereview.chromium.org/7033033/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_input_ui_api.h (right):

http://codereview.chromium.org/7033033/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_input_ui_api.h:11: #if defined(OS_CHROMEOS)
Using the macros in this way makes this file hard to understand.

Why not just put this functionality into extension_input_api.* until we refactor
these files?

[sadrul, 2011-05-19 22:30:00]

[drive-by qq for clarification]

http://codereview.chromium.org/7033033/diff/1/chrome/browser/ui/touch/frame/t...
File chrome/browser/ui/touch/frame/touch_browser_frame_view.cc (right):

http://codereview.chromium.org/7033033/diff/1/chrome/browser/ui/touch/frame/t...
chrome/browser/ui/touch/frame/touch_browser_frame_view.cc:281:
UpdateKeyboardAndLayout(false);
In case the web-page (RWHVV) is currently in focus, should this also reset the
state of page (the property-bag for the tab-contents) so that when the user gets
back to this page after tab-switching, the keyboard remains hidden even though
an editable entry will have the focus?

[bryeung, 2011-05-19 22:39:24]

Can you sync and re-upload?

This fails to apply cleanly for me.

[mazda, 2011-05-20 12:16:05]

Thank you for the comments.
Could you take another look at the change?

http://codereview.chromium.org/7033033/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_function_dispatcher.cc (right):

http://codereview.chromium.org/7033033/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_function_dispatcher.cc:278: #if
defined(OS_CHROMEOS)
On 2011/05/19 22:23:42, bryeung wrote:
> Is this suggested style?
> 
> I'd prefer we did not nest #ifs, and had separate TOUCH_UI && OS_CHROMEOS and
> TOUCH_UI sections.

I moved the code to extension_input_api.* and reverted the change here.

http://codereview.chromium.org/7033033/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_input_ui_api.h (right):

http://codereview.chromium.org/7033033/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_input_ui_api.h:11: #if defined(OS_CHROMEOS)
On 2011/05/19 22:23:42, bryeung wrote:
> Using the macros in this way makes this file hard to understand.
> 
> Why not just put this functionality into extension_input_api.* until we
refactor
> these files?

OK. I moved the code to extension_input_api.*.
Let's revisit when we will finalize input and inputUI namespaces.

http://codereview.chromium.org/7033033/diff/1/chrome/browser/ui/touch/frame/t...
File chrome/browser/ui/touch/frame/touch_browser_frame_view.cc (right):

http://codereview.chromium.org/7033033/diff/1/chrome/browser/ui/touch/frame/t...
chrome/browser/ui/touch/frame/touch_browser_frame_view.cc:281:
UpdateKeyboardAndLayout(false);
On 2011/05/19 22:30:00, sadrul wrote:
> In case the web-page (RWHVV) is currently in focus, should this also reset the
> state of page (the property-bag for the tab-contents) so that when the user
gets
> back to this page after tab-switching, the keyboard remains hidden even though
> an editable entry will have the focus?

I added code to reset property-bag. Thanks.

[bryeung, 2011-05-20 17:42:03]

LGTM, after renaming

There is still one problem with this CL: it is not possible to summon the
keyboard by clicking on an already focused text field.  But the fix for that
might be too large to include in this CL.  I'm fine with this CL going in, so
long as we fix that in a follow-up.

http://codereview.chromium.org/7033033/diff/6001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_input_api.h (right):

http://codereview.chromium.org/7033033/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_input_api.h:37: class
HideKeyboardInputFunction : public AsyncExtensionFunction {
Please remove Input from the name.

[mazda, 2011-05-20 19:03:59]

Thanks for the comment.
I'll file a bug and fix the keyboard so that clicking on an focused field will
summon the hidden keyboard.

http://codereview.chromium.org/7033033/diff/6001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_input_api.h (right):

http://codereview.chromium.org/7033033/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_input_api.h:37: class
HideKeyboardInputFunction : public AsyncExtensionFunction {
On 2011/05/20 17:42:03, bryeung wrote:
> Please remove Input from the name.

Done.

[Peng, 2011-05-20 19:11:57]

On 2011/05/20 17:42:03, bryeung wrote:
> LGTM, after renaming
> 
> There is still one problem with this CL: it is not possible to summon the
> keyboard by clicking on an already focused text field.  But the fix for that
> might be too large to include in this CL.  I'm fine with this CL going in, so
> long as we fix that in a follow-up.

I think if the keyboard is already hidden, and user touches a textfield, the
keyboard should become visible again.
But if user uses mouse click on a textfield. the keyboard should keep invisible.
Because the user probably do want to use vk and mouse at same time. Please
consider it in the follow-up. Anyway, this CL is LGTM.

> 
>
http://codereview.chromium.org/7033033/diff/6001/chrome/browser/extensions/ex...
> File chrome/browser/extensions/extension_input_api.h (right):
> 
>
http://codereview.chromium.org/7033033/diff/6001/chrome/browser/extensions/ex...
> chrome/browser/extensions/extension_input_api.h:37: class
> HideKeyboardInputFunction : public AsyncExtensionFunction {
> Please remove Input from the name.

[mazda, 2011-05-23 04:44:08]

On 2011/05/20 19:11:57, Peng wrote:
> On 2011/05/20 17:42:03, bryeung wrote:
> > LGTM, after renaming
> > 
> > There is still one problem with this CL: it is not possible to summon the
> > keyboard by clicking on an already focused text field.  But the fix for that
> > might be too large to include in this CL.  I'm fine with this CL going in,
so
> > long as we fix that in a follow-up.
> 
> I think if the keyboard is already hidden, and user touches a textfield, the
> keyboard should become visible again.
> But if user uses mouse click on a textfield. the keyboard should keep
invisible.
> Because the user probably do want to use vk and mouse at same time. Please
> consider it in the follow-up. Anyway, this CL is LGTM.
> 
> > 
> >
>
http://codereview.chromium.org/7033033/diff/6001/chrome/browser/extensions/ex...
> > File chrome/browser/extensions/extension_input_api.h (right):
> > 
> >
>
http://codereview.chromium.org/7033033/diff/6001/chrome/browser/extensions/ex...
> > chrome/browser/extensions/extension_input_api.h:37: class
> > HideKeyboardInputFunction : public AsyncExtensionFunction {
> > Please remove Input from the name.

OK. I'll add your idea to the bug description. Thanks.

[mazda, 2011-05-23 06:08:34]

Hello John

Could you review this patch?
I need owner's approval for content/common/notification_type.h.

Thanks,

[jam, 2011-05-23 17:01:16]

content lgtm

[commit-bot: I haz the power, 2011-05-23 18:52:57]

Presubmit check for 7033033-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **

This change modifies file(s) which the extension docs depend on. You must
rebuild the extension docs.

Build by running the build.py script in chrome/common/extensions/docs/build/.

Be sure to include any modified resulting static files
(/common/extension/docs/*.html) in your final changelist.