Add hideKeyboard API to chrome.experimental.input.

chrome/browser/extensions/extension_function_dispatcher.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_function_dispatcher.h"
 
 #include <map>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/singleton.h"
@@ skipping 42 matching lines @@
 #include "content/browser/renderer_host/render_process_host.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_message_macros.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 #if defined(TOOLKIT_VIEWS)
 #include "chrome/browser/extensions/extension_input_api.h"
 #endif
 
-#if defined(OS_CHROMEOS) && defined(TOUCH_UI)
+#if defined(TOUCH_UI)
 #include "chrome/browser/extensions/extension_input_ui_api.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/extensions/extension_file_browser_private_api.h"
 #include "chrome/browser/extensions/extension_info_private_api_chromeos.h"
 #endif
 
 // FactoryRegistry -------------------------------------------------------------
 
@@ skipping 193 matching lines @@
   RegisterFunction<SetBadgeTextSidebarFunction>();
   RegisterFunction<SetIconSidebarFunction>();
   RegisterFunction<SetTitleSidebarFunction>();
   RegisterFunction<ShowSidebarFunction>();
 
 #if defined(TOOLKIT_VIEWS)
   // Input.
   RegisterFunction<SendKeyboardEventInputFunction>();
 #endif
 
-#if defined(OS_CHROMEOS) && defined(TOUCH_UI)
+#if defined(TOUCH_UI)
+#if defined(OS_CHROMEOS)

[bryeung, 2011/05/19 22:23:42]

Is this suggested style?

I'd prefer we did not nest #ifs, and had separate TOUCH_UI && OS_CHROMEOS and
TOUCH_UI sections.

[mazda, 2011/05/20 12:16:05]

I moved the code to extension_input_api.* and reverted the change here.

   // IME
   RegisterFunction<CandidateClickedInputUiFunction>();
   RegisterFunction<CursorUpInputUiFunction>();
   RegisterFunction<CursorDownInputUiFunction>();
   RegisterFunction<PageUpInputUiFunction>();
   RegisterFunction<PageDownInputUiFunction>();
   RegisterFunction<RegisterInputUiFunction>();
   RegisterFunction<PageUpInputUiFunction>();
   RegisterFunction<PageDownInputUiFunction>();
-#endif
+#endif  // OS_CHROMEOS
+  RegisterFunction<HideKeyboardInputUiFunction>();
+#endif  // TOUCH_UI
 
   // Management.
   RegisterFunction<GetAllExtensionsFunction>();
   RegisterFunction<GetExtensionByIdFunction>();
   RegisterFunction<LaunchAppFunction>();
   RegisterFunction<SetEnabledFunction>();
   RegisterFunction<UninstallFunction>();
 
   // Extension module.
   RegisterFunction<SetUpdateUrlDataFunction>();
@@ skipping 203 matching lines @@
         std::string(), QuotaLimitHeuristic::kGenericOverQuotaError));
   }
 }
 
 void ExtensionFunctionDispatcher::SendAccessDenied(
     RenderViewHost* render_view_host, int request_id) {
   render_view_host->Send(new ExtensionMsg_Response(
       render_view_host->routing_id(), request_id, false, std::string(),
       "Access to extension API denied."));
 }