Implement A/B experiment for anti-DDoS.

chrome/browser/trials/throttling_trial.h

Index: chrome/browser/trials/throttling_trial.h
diff --git a/chrome/browser/trials/throttling_trial.h b/chrome/browser/trials/throttling_trial.h
new file mode 100644
index 0000000000000000000000000000000000000000..bbea7d4586f0ce022eb847b5144220f1f7ab60a9
--- /dev/null
+++ b/chrome/browser/trials/throttling_trial.h
@@ -0,0 +1,20 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_TRIALS_THROTTLING_TRIAL_H_
+#define CHROME_BROWSER_TRIALS_THROTTLING_TRIAL_H_
+#pragma once
+
+#include <string>

[wtc, 2011/06/10 22:31:00]

Nit: no need to include <string> because this header doesn't
use std::string, etc.

[Jói, 2011/06/13 17:27:14]

Done.

+
+class PrefService;
+
+namespace throttling_trial {

[wtc, 2011/06/10 22:31:00]

Nit: it seems better to name the namespace http_throttling
because throttling is vague.

[Jói, 2011/06/13 17:27:14]

I went with Jim's suggestion to remove the namespace instead. The function is
now called CreateHttpThrottlingTrial.

+
+// Creates the trial.
+void CreateTrial(PrefService* prefs);

[jar (doing other things), 2011/06/12 06:49:12]

This seems strange.  You're declaring a namespace (it would seem) to declare
only one item in that namespace.  Namespaces are traditionally defined to reduce
global namespace polution... but it is costing you one element of polution to
preclude one elements :-/.

I'd suggest that you should just name the function well.

I think it is for instance more common to define a namespace that corresponds to
a directory... and include a LOT of names... but that does not seem to be
happening.

[Jói, 2011/06/13 17:27:14]

You're absolutely right, thanks for pointing this out.  What happened was I
initially had a few functions in the namespace and then as implementation
progressed it simplified to just one.  I've removed the namespace and named the
function CreateHttpThrottlingTrial.

+
+}  // namespace throttling_trial
+
+#endif  // CHROME_BROWSER_TRIALS_THROTTLING_TRIAL_H_