chrome/browser/trials/throttling_trial.h - Issue 7027040: Implement A/B experiment for anti-DDoS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/trials/throttling_trial.h

Issue 7027040: Implement A/B experiment for anti-DDoS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_TRIALS_THROTTLING_TRIAL_H_

	6 #define CHROME_BROWSER_TRIALS_THROTTLING_TRIAL_H_

	7 #pragma once

	8

	9 #include <string>
	wtc 2011/06/10 22:31:00 Nit: no need to include <string> because this head Nit: no need to include <string> because this header doesn't use std::string, etc. Jói 2011/06/13 17:27:14 Done. Show quoted text On 2011/06/10 22:31:00, wtc wrote: > Nit: no need to include <string> because this header doesn't > use std::string, etc. Done.
	10

	11 class PrefService;

	12

	13 namespace throttling_trial {
	wtc 2011/06/10 22:31:00 Nit: it seems better to name the namespace http_th Nit: it seems better to name the namespace http_throttling because throttling is vague. Jói 2011/06/13 17:27:14 I went with Jim's suggestion to remove the namespa Show quoted text On 2011/06/10 22:31:00, wtc wrote: > Nit: it seems better to name the namespace http_throttling > because throttling is vague. I went with Jim's suggestion to remove the namespace instead. The function is now called CreateHttpThrottlingTrial.
	14

	15 // Creates the trial.

	16 void CreateTrial(PrefService* prefs);
	jar (doing other things) 2011/06/12 06:49:12 This seems strange. You're declaring a namespace This seems strange. You're declaring a namespace (it would seem) to declare only one item in that namespace. Namespaces are traditionally defined to reduce global namespace polution... but it is costing you one element of polution to preclude one elements :-/. I'd suggest that you should just name the function well. I think it is for instance more common to define a namespace that corresponds to a directory... and include a LOT of names... but that does not seem to be happening. Jói 2011/06/13 17:27:14 You're absolutely right, thanks for pointing this Show quoted text On 2011/06/12 06:49:12, jar wrote: > This seems strange. You're declaring a namespace (it would seem) to declare > only one item in that namespace. Namespaces are traditionally defined to reduce > global namespace polution... but it is costing you one element of polution to > preclude one elements :-/. > > I'd suggest that you should just name the function well. > > I think it is for instance more common to define a namespace that corresponds to > a directory... and include a LOT of names... but that does not seem to be > happening. You're absolutely right, thanks for pointing this out. What happened was I initially had a few functions in the namespace and then as implementation progressed it simplified to just one. I've removed the namespace and named the function CreateHttpThrottlingTrial.
	17

	18 } // namespace throttling_trial

	19

	20 #endif // CHROME_BROWSER_TRIALS_THROTTLING_TRIAL_H_

OLD	NEW

« base/metrics/field_trial.cc ('K') | « chrome/browser/net/net_pref_observer.cc ('k') | chrome/browser/trials/throttling_trial.cc » ('j') | chrome/browser/trials/throttling_trial.cc » ('J')