Issue 7024058: [Sync] Clean up sync logging

Issue 7024058: [Sync] Clean up sync logging (Closed)

Created:
9 years, 6 months ago by akalin

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, Nicolas Zea, willchan no longer on Chromium, M-A Ruel

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, kkania, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Clean up sync logging Add GetDebugName() method to Profile. Use it in ProfileSyncServiceHarness, SyncerThread, and LiveSyncExtensionHelper. Change VLOG(1)s in SyncerThread to VLOG(2)s. Turn on logging for the test server if VLOG is enabled for that file, and not just in general. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88355

Patch Set 1 #

Patch Set 2 : Fix lint #

Patch Set 3 : Add more logging #

Patch Set 4 : even more logging #

Total comments: 10

Patch Set 5 : Fix comments #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+264 lines, -228 lines)			Patch
M	chrome/browser/automation/testing_automation_provider.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/profile.h	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile.cc	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/syncapi.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/engine/syncapi.cc	View	1 2	6 chunks	+20 lines, -8 lines	0 comments	Download
M	chrome/browser/sync/engine/syncapi_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	chrome/browser/sync/engine/syncer.cc	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_thread.h	View	1	3 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_thread.cc	View	1 2 3 4	30 chunks	+79 lines, -87 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_thread_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/engine/syncer_thread_whitebox_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.h	View		3 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.cc	View	1 2 3 4	34 chunks	+101 lines, -99 lines	0 comments	Download
M	chrome/browser/sync/sessions/session_state.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/sessions/session_state.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/test/live_sync/live_sync_extension_helper.cc	View		6 chunks	+5 lines, -15 lines	0 comments	Download
M	chrome/test/live_sync/live_sync_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/test/test_server.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

LGTM with nits. http://codereview.chromium.org/7024058/diff/15003/chrome/browser/sync/engine/syncer_thread.cc File chrome/browser/sync/engine/syncer_thread.cc (right): http://codereview.chromium.org/7024058/diff/15003/chrome/browser/sync/engine/syncer_thread.cc#newcode193 chrome/browser/sync/engine/syncer_thread.cc:193: << wait_interval_->mode << "Wait interval had ...

9 years, 6 months ago (2011-06-07 19:55:24 UTC) #2

akalin

Addressed everything, committing. http://codereview.chromium.org/7024058/diff/15003/chrome/browser/sync/engine/syncer_thread.cc File chrome/browser/sync/engine/syncer_thread.cc (right): http://codereview.chromium.org/7024058/diff/15003/chrome/browser/sync/engine/syncer_thread.cc#newcode193 chrome/browser/sync/engine/syncer_thread.cc:193: << wait_interval_->mode << "Wait interval had ...

9 years, 6 months ago (2011-06-07 20:17:38 UTC) #3

commit-bot: I haz the power

Can't process patch for file chrome/browser/sync/engine/syncer.cc. File's status is None, patchset upload is incomplete.

9 years, 6 months ago (2011-06-07 20:17:53 UTC) #4

commit-bot: I haz the power

Can't process patch for file chrome/browser/sync/engine/syncer.cc. File's status is None, patchset upload is incomplete.

9 years, 6 months ago (2011-06-08 17:42:42 UTC) #7

M-A Ruel

9 years, 6 months ago (2011-06-08 17:43:41 UTC) #8

On 2011/06/08 17:42:42, I haz the power (commit-bot) wrote:
> Can't process patch for file chrome/browser/sync/engine/syncer.cc.
> File's status is None, patchset upload is incomplete.

I'm not sure what's causing this. If you have any idea how to reproduce the
empty status that would be appreciated.

Expand Messages | Collapse Messages