Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2323)

Unified Diff: chrome/browser/sync/profile_sync_service_harness.h

Issue 7024058: [Sync] Clean up sync logging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix comments Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host.cc ('k') | chrome/browser/sync/profile_sync_service_harness.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service_harness.h
diff --git a/chrome/browser/sync/profile_sync_service_harness.h b/chrome/browser/sync/profile_sync_service_harness.h
index 3053e99695726b75dc189ae044ce8ffe39858221..54ad1d2315fe3756fd5de55dfc8b9f8de66ad945 100644
--- a/chrome/browser/sync/profile_sync_service_harness.h
+++ b/chrome/browser/sync/profile_sync_service_harness.h
@@ -31,8 +31,7 @@ class ProfileSyncServiceHarness : public ProfileSyncServiceObserver {
public:
ProfileSyncServiceHarness(Profile* profile,
const std::string& username,
- const std::string& password,
- int id);
+ const std::string& password);
virtual ~ProfileSyncServiceHarness() {}
@@ -220,9 +219,9 @@ class ProfileSyncServiceHarness : public ProfileSyncServiceObserver {
// other client has.
bool MatchesOtherClient(ProfileSyncServiceHarness* partner);
- // Logs message with relevant info about client's sync state (if available).
- // |log_level| denotes the VLOG level.
- void LogClientInfo(const std::string& message, int log_level);
+ // Returns a string with relevant info about client's sync state (if
+ // available). Useful for logging.
+ std::string GetClientInfo();
// Gets the current progress indicator of the current sync session
// for a particular datatype.
@@ -253,8 +252,8 @@ class ProfileSyncServiceHarness : public ProfileSyncServiceObserver {
std::string username_;
std::string password_;
- // Client ID, used for logging purposes.
- int id_;
+ // Used for logging.
+ const std::string profile_debug_name_;
DISALLOW_COPY_AND_ASSIGN(ProfileSyncServiceHarness);
};
« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host.cc ('k') | chrome/browser/sync/profile_sync_service_harness.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698