Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4816)

Unified Diff: chrome/browser/ui/views/keyboard_overlay_dialog_view.cc

Issue 7024032: Wait showing html dialog until renderer finish painting after page is loaded. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
diff --git a/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc b/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
index 7da848c78e7c6b42e0ce9c88d2fb8aab054b7d77..d2c77403335fd486fa40a9fe947f2c7256e2464b 100644
--- a/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
+++ b/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
@@ -12,6 +12,7 @@
#include "chrome/browser/ui/views/window.h"
#include "content/browser/tab_contents/tab_contents.h"
#include "content/common/native_web_keyboard_event.h"
+#include "content/common/notification_source.h"
mazda 2011/06/07 03:26:58 Is this necessary?
oshima 2011/06/07 19:08:58 Done.
#include "grit/generated_resources.h"
#include "ui/base/keycodes/keyboard_codes.h"
#include "ui/base/l10n/l10n_util.h"
@@ -44,16 +45,7 @@ KeyboardOverlayDialogView::KeyboardOverlayDialogView(
KeyboardOverlayDialogView::~KeyboardOverlayDialogView() {
}
-void KeyboardOverlayDialogView::InitDialog() {
- DOMView::Init(profile(), NULL);
-
- tab_contents_->set_delegate(this);
-
- // Set the delegate. This must be done before loading the page. See
- // the comment above HtmlDialogUI in its header file for why.
- HtmlDialogUI::GetPropertyAccessor().SetProperty(tab_contents_->property_bag(),
- this);
-
+void KeyboardOverlayDialogView::RegisterDialogAccelerators() {
for (size_t i = 0; i < arraysize(kCloseAccelerators); ++i) {
views::Accelerator accelerator(kCloseAccelerators[i].keycode,
kCloseAccelerators[i].shift_pressed,
@@ -78,8 +70,6 @@ void KeyboardOverlayDialogView::InitDialog() {
}
AddAccelerator(accelerator);
}
-
- DOMView::LoadURL(GetDialogContentURL());
}
bool KeyboardOverlayDialogView::AcceleratorPressed(

Powered by Google App Engine
This is Rietveld 408576698