Wait showing html dialog until renderer finish painting after page is loaded.

chrome/browser/ui/views/keyboard_overlay_dialog_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/keyboard_overlay_dialog_view.h"
 
 #include "chrome/browser/chromeos/frame/bubble_window.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/views/accelerator_table_gtk.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/keyboard_overlay_delegate.h"
 #include "chrome/browser/ui/views/window.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/common/native_web_keyboard_event.h"
+#include "content/common/notification_source.h"

[mazda, 2011/06/07 03:26:58]

Is this necessary?

[oshima, 2011/06/07 19:08:58]

Done.

 #include "grit/generated_resources.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "views/events/event.h"
 #include "views/widget/root_view.h"
 #include "views/widget/widget.h"
 #include "views/window/window.h"
 
 namespace {
 struct Accelerator {
@@ skipping 12 matching lines @@
     Profile* profile,
     HtmlDialogUIDelegate* delegate,
     BrowserView* parent_view)
     : HtmlDialogView(profile, delegate),
       parent_view_(parent_view) {
 }
 
 KeyboardOverlayDialogView::~KeyboardOverlayDialogView() {
 }
 
-void KeyboardOverlayDialogView::InitDialog() {
-  DOMView::Init(profile(), NULL);
-
-  tab_contents_->set_delegate(this);
-
-  // Set the delegate. This must be done before loading the page. See
-  // the comment above HtmlDialogUI in its header file for why.
-  HtmlDialogUI::GetPropertyAccessor().SetProperty(tab_contents_->property_bag(),
-                                                  this);
-
+void KeyboardOverlayDialogView::RegisterDialogAccelerators() {
   for (size_t i = 0; i < arraysize(kCloseAccelerators); ++i) {
     views::Accelerator accelerator(kCloseAccelerators[i].keycode,
                                    kCloseAccelerators[i].shift_pressed,
                                    kCloseAccelerators[i].ctrl_pressed,
                                    kCloseAccelerators[i].alt_pressed);
     close_accelerators_.insert(accelerator);
     AddAccelerator(accelerator);
   }
 
   for (size_t i = 0; i < browser::kAcceleratorMapLength; ++i) {
     views::Accelerator accelerator(browser::kAcceleratorMap[i].keycode,
                                    browser::kAcceleratorMap[i].shift_pressed,
                                    browser::kAcceleratorMap[i].ctrl_pressed,
                                    browser::kAcceleratorMap[i].alt_pressed);
     // Skip a sole ALT key since it's handled on the keyboard overlay.
     if (views::Accelerator(ui::VKEY_MENU, false, false, false) == accelerator) {
       continue;
     }
     // Skip accelerators for closing the dialog since they are already added.
     if (IsCloseAccelerator(accelerator)) {
       continue;
     }
     AddAccelerator(accelerator);
   }
-
-  DOMView::LoadURL(GetDialogContentURL());
 }
 
 bool KeyboardOverlayDialogView::AcceleratorPressed(
     const views::Accelerator& accelerator) {
   if (!IsCloseAccelerator(accelerator)) {
     parent_view_->AcceleratorPressed(accelerator);
   }
   OnDialogClosed(std::string());
   return true;
 }
@@ skipping 12 matching lines @@
                                  gfx::Rect(),
                                  chromeos::BubbleWindow::STYLE_XSHAPE,
                                  html_view);
   html_view->window()->Show();
 }
 
 bool KeyboardOverlayDialogView::IsCloseAccelerator(
     const views::Accelerator& accelerator) {
   return close_accelerators_.find(accelerator) != close_accelerators_.end();
 }