Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: ppapi/c/dev/ppp_video_decoder_dev.h

Issue 7021020: Clean up video frame sizes, types in Video Decode API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/c/dev/ppp_video_decoder_dev.h
diff --git a/ppapi/c/dev/ppp_video_decoder_dev.h b/ppapi/c/dev/ppp_video_decoder_dev.h
index af5eaaf2f7d29cf65ac684c34a7b1e7192f83fe9..c3687e5504c4e8e95e703ee220dfbc15da0819ce 100644
--- a/ppapi/c/dev/ppp_video_decoder_dev.h
+++ b/ppapi/c/dev/ppp_video_decoder_dev.h
@@ -7,7 +7,7 @@
#include "ppapi/c/dev/pp_video_dev.h"
-#define PPP_VIDEODECODER_DEV_INTERFACE "PPP_VideoDecoder(Dev);0.3"
+#define PPP_VIDEODECODER_DEV_INTERFACE "PPP_VideoDecoder(Dev);0.4"
// PPP_VideoDecoder_Dev structure contains the function pointers that the
// plugin MUST implement to provide services needed by the video decoder
@@ -24,12 +24,8 @@ struct PPP_VideoDecoder_Dev {
// |decoder| is pointer to the Pepper Video Decoder instance.
// |req_num_of_bufs| tells how many buffers are needed by the decoder.
// |dimensions| tells the dimensions of the buffer to allocate.
- // |type| specifies whether the buffer lives in system memory or GL texture.
void (*ProvidePictureBuffers)(
- PP_Resource decoder,
- uint32_t req_num_of_bufs,
- struct PP_Size dimensions,
- enum PP_PictureBufferType_Dev type);
Ami GONE FROM CHROMIUM 2011/05/16 20:17:50 Previously, the API allowed the decoder to specify
vrk (LEFT CHROMIUM) 2011/05/16 20:28:37 Yes, intentional. (I think we talked about it on F
Ville-Mikko Rautio 2011/05/17 08:58:49 But it is possible that the decoder implementation
vrk (LEFT CHROMIUM) 2011/05/23 18:20:29 I don't think this is true; see response.
+ PP_Resource decoder, uint32_t req_num_of_bufs, struct PP_Size dimensions);
// Callback function for decoder to deliver unneeded picture buffers back to
// the plugin.

Powered by Google App Engine
This is Rietveld 408576698