Clean up video frame sizes, types in Video Decode API

ppapi/c/dev/ppp_video_decoder_dev.h

 /* Copyright (c) 2011 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #ifndef PPAPI_C_DEV_PPP_VIDEO_DECODER_DEV_H_
 #define PPAPI_C_DEV_PPP_VIDEO_DECODER_DEV_H_
 
 #include "ppapi/c/dev/pp_video_dev.h"
 
-#define PPP_VIDEODECODER_DEV_INTERFACE "PPP_VideoDecoder(Dev);0.3"
+#define PPP_VIDEODECODER_DEV_INTERFACE "PPP_VideoDecoder(Dev);0.4"
 
 // PPP_VideoDecoder_Dev structure contains the function pointers that the
 // plugin MUST implement to provide services needed by the video decoder
 // implementation.
 struct PPP_VideoDecoder_Dev {
   // Callback function to provide buffers for the decoded output pictures. If
   // succeeds plugin must provide buffers through AssignPictureBuffers function
   // to the API. If |req_num_of_bufs| matching exactly the specification
   // given in the parameters cannot be allocated decoder should be destroyed.
   //
   // Decoding will not proceed until buffers have been provided.
   //
   // Parameters:
   //  |decoder| is pointer to the Pepper Video Decoder instance.
   //  |req_num_of_bufs| tells how many buffers are needed by the decoder.
   //  |dimensions| tells the dimensions of the buffer to allocate.
-  //  |type| specifies whether the buffer lives in system memory or GL texture.
   void (*ProvidePictureBuffers)(
-      PP_Resource decoder,
-      uint32_t req_num_of_bufs,
-      struct PP_Size dimensions,
-      enum PP_PictureBufferType_Dev type);

[Ami GONE FROM CHROMIUM, 2011/05/16 20:17:50]

Previously, the API allowed the decoder to specify which type of buffers it
wants to render into.  This change makes it look like the plugin gets to decide
what to provide to the decoder.  Intentional?

[vrk (LEFT CHROMIUM), 2011/05/16 20:28:37]

Yes, intentional. (I think we talked about it on Friday that it seems to make
more sense this way; decoder should never have "preference" for output buffer
type, but the plugin might.)

[Ville-Mikko Rautio, 2011/05/17 08:58:49]

But it is possible that the decoder implementation might support only one of the
types. See previous comment.

[vrk (LEFT CHROMIUM), 2011/05/23 18:20:29]

I don't think this is true; see response.

+      PP_Resource decoder, uint32_t req_num_of_bufs, struct PP_Size dimensions);
 
   // Callback function for decoder to deliver unneeded picture buffers back to
   // the plugin.
   //
   // Parameters:
   //  |decoder| is pointer to the Pepper Video Decoder instance.
   //  |picture_buffer| points to the picture buffer that is no longer needed.
   void (*DismissPictureBuffer)(PP_Resource decoder,
                                int32_t picture_buffer_id);
 
@@ skipping 20 matching lines @@
   //
   // TODO(vmr): Fill out error result codes and corresponding actions.
   //
   // Parameters:
   //  |decoder| is pointer to the Pepper Video Decoder instance.
   //  |error| error is the enumeration specifying the error.
   void (*NotifyError)(PP_Resource decoder, enum PP_VideoDecodeError_Dev error);
 };
 
 #endif  /* PPAPI_C_DEV_PPP_VIDEO_DECODER_DEV_H_ */