Chromium Code Reviews Chromium Code Reviews
Issue
7017028:
Revert "Revert 85330 - GTK: Bring global menu out of about:flags." (Closed)
DescriptionGTK: Take 2: Bring global menu out of about:flags.
This makes some substantial changes to
1) The ownership model needed to change slightly; Global{Bookmark,History}Menu needed to own its GtkMenu due to timing issues. (The other possible way to do this (use gtk_widget_destroyed to NULL out the reference) was discussed and rejected in a similar recent code review).
2) The first connection to the TabRestoreService needs to happen lazily. While this doesn't appear to have any affect during normal startup, it breaks the majority of browser, ui and unit tests that depend on the TabRestoreService because they all depend on controlling the loading state. We can't use the OnShow/PostTask method (see previous CL) so connect to the GtkMenuItem's activate signal.
BUG=30213
TEST=ui_tests and browser_tests pass
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86328
Patch Set 1 #Patch Set 2 : Removing global menu bar for a tryrun #Patch Set 3 : Try with the tab restore service stuff commented out #Patch Set 4 : Check which TopSites object we're receiving a notification from #Patch Set 5 : Debugging output for in the tests. #Patch Set 6 : more logging for output #Patch Set 7 : Apparently logging makes it work. Trying something for real. #Patch Set 8 : Going to call the previous ones fixed. #Patch Set 9 : Comment out LoadTabsFromLastSession #Patch Set 10 : Make unit tests disable loading #Patch Set 11 : OK, maybe ownership + timing issues fixed #Patch Set 12 : Final clean up? #Patch Set 13 : Rebase #Messages
Total messages: 2 (0 generated)
|
