Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: chrome/browser/ui/gtk/browser_window_gtk.cc

Issue 7017028: Revert "Revert 85330 - GTK: Bring global menu out of about:flags." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/gtk/global_bookmark_menu.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/browser_window_gtk.h" 5 #include "chrome/browser/ui/gtk/browser_window_gtk.h"
6 6
7 #include <gdk/gdkkeysyms.h> 7 #include <gdk/gdkkeysyms.h>
8 8
9 #include <dlfcn.h> 9 #include <dlfcn.h>
10 #include <string> 10 #include <string>
(...skipping 1593 matching lines...) Expand 10 before | Expand all | Expand 10 after
1604 1604
1605 // This vbox encompasses all of the widgets within the browser. This is 1605 // This vbox encompasses all of the widgets within the browser. This is
1606 // everything except the custom frame border. 1606 // everything except the custom frame border.
1607 window_vbox_ = gtk_vbox_new(FALSE, 0); 1607 window_vbox_ = gtk_vbox_new(FALSE, 0);
1608 gtk_widget_show(window_vbox_); 1608 gtk_widget_show(window_vbox_);
1609 1609
1610 // We hold an always hidden GtkMenuBar inside our browser window simply to 1610 // We hold an always hidden GtkMenuBar inside our browser window simply to
1611 // fool the Unity desktop, which will mirror the contents of the first 1611 // fool the Unity desktop, which will mirror the contents of the first
1612 // GtkMenuBar it sees into the global menu bar. (It doesn't seem to check the 1612 // GtkMenuBar it sees into the global menu bar. (It doesn't seem to check the
1613 // visibility of the GtkMenuBar, so we can just permanently hide it.) 1613 // visibility of the GtkMenuBar, so we can just permanently hide it.)
1614 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kGlobalGnomeMenu)) { 1614 global_menu_bar_.reset(new GlobalMenuBar(browser_.get()));
1615 global_menu_bar_.reset(new GlobalMenuBar(browser_.get())); 1615 gtk_container_add(GTK_CONTAINER(window_vbox_), global_menu_bar_->widget());
1616 gtk_container_add(GTK_CONTAINER(window_vbox_), global_menu_bar_->widget());
1617 }
1618 1616
1619 // The window container draws the custom browser frame. 1617 // The window container draws the custom browser frame.
1620 window_container_ = gtk_alignment_new(0.0, 0.0, 1.0, 1.0); 1618 window_container_ = gtk_alignment_new(0.0, 0.0, 1.0, 1.0);
1621 gtk_widget_set_name(window_container_, "chrome-custom-frame-border"); 1619 gtk_widget_set_name(window_container_, "chrome-custom-frame-border");
1622 gtk_widget_set_app_paintable(window_container_, TRUE); 1620 gtk_widget_set_app_paintable(window_container_, TRUE);
1623 gtk_widget_set_double_buffered(window_container_, FALSE); 1621 gtk_widget_set_double_buffered(window_container_, FALSE);
1624 gtk_widget_set_redraw_on_allocate(window_container_, TRUE); 1622 gtk_widget_set_redraw_on_allocate(window_container_, TRUE);
1625 g_signal_connect(window_container_, "expose-event", 1623 g_signal_connect(window_container_, "expose-event",
1626 G_CALLBACK(OnCustomFrameExposeThunk), this); 1624 G_CALLBACK(OnCustomFrameExposeThunk), this);
1627 gtk_container_add(GTK_CONTAINER(window_container_), window_vbox_); 1625 gtk_container_add(GTK_CONTAINER(window_container_), window_vbox_);
(...skipping 745 matching lines...) Expand 10 before | Expand all | Expand 10 after
2373 // are taken from the WMs' source code. 2371 // are taken from the WMs' source code.
2374 return (wm_name == "Blackbox" || 2372 return (wm_name == "Blackbox" ||
2375 wm_name == "compiz" || 2373 wm_name == "compiz" ||
2376 wm_name == "Compiz" || 2374 wm_name == "Compiz" ||
2377 wm_name == "e16" || // Enlightenment DR16 2375 wm_name == "e16" || // Enlightenment DR16
2378 wm_name == "Metacity" || 2376 wm_name == "Metacity" ||
2379 wm_name == "Mutter" || 2377 wm_name == "Mutter" ||
2380 wm_name == "Openbox" || 2378 wm_name == "Openbox" ||
2381 wm_name == "Xfwm4"); 2379 wm_name == "Xfwm4");
2382 } 2380 }
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/gtk/global_bookmark_menu.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698