Trying to move derived get trap from builtins to global context.

Move derived get trap from builtins to global context.

Committed: http://code.google.com/p/v8/source/detail?r=7936

[Mads Ager (chromium), 2011-05-18 13:11:33]

LGTM

http://codereview.chromium.org/7017008/diff/5007/src/proxy.js
File src/proxy.js (right):

http://codereview.chromium.org/7017008/diff/5007/src/proxy.js#newcode74
src/proxy.js:74: function DERIVED_GET_TRAP(receiver, name) {
Let's change the naming here: DerivedGetTrap?

http://codereview.chromium.org/7017008/diff/5007/src/proxy.js#newcode81
src/proxy.js:81: return desc.get().call(receiver)  // The proposal says so...
Does the proposal even say to use Function.prototype.call? That one can get
overwritten by user code to do something else? If is just says to perform a call
you can use the %_CallFunction support in our natives to make this independent
of Function.prototype.call.

[rossberg, 2011-05-18 13:34:57]

http://codereview.chromium.org/7017008/diff/5007/src/proxy.js
File src/proxy.js (right):

http://codereview.chromium.org/7017008/diff/5007/src/proxy.js#newcode74
src/proxy.js:74: function DERIVED_GET_TRAP(receiver, name) {
On 2011/05/18 13:11:33, Mads Ager wrote:
> Let's change the naming here: DerivedGetTrap?

Done.

http://codereview.chromium.org/7017008/diff/5007/src/proxy.js#newcode81
src/proxy.js:81: return desc.get().call(receiver)  // The proposal says so...
On 2011/05/18 13:11:33, Mads Ager wrote:
> Does the proposal even say to use Function.prototype.call? That one can get
> overwritten by user code to do something else? If is just says to perform a
call
> you can use the %_CallFunction support in our natives to make this independent
> of Function.prototype.call.

Good question. The spec gives it literally in JS code, using `call' like here,
so it's not clear what the real intention is. I'm also puzzled about passing
`receiver'. I've put that on my list of questions regarding proxy semantics.

In any case, the extra () where a typo on my side. :)