src/objects.cc - Issue 7017008: Trying to move derived get trap from builtins to global context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 7017008: Trying to move derived get trap from builtins to global context. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 8c7695db535a1d70162fa635a311a21b55900da9..f62f1ca1c9e7bde6eaf5a8ef61c67341522c089a 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -239,9 +239,7 @@ MaybeObject* Object::GetPropertyWithHandler(Object* receiver_raw,

Handle<Object> trap(v8::internal::GetProperty(handler, "get", &lookup));

if (!lookup.IsFound()) {

// Get the derived `get' property.

- Object* derived = isolate->global_context()->builtins()->javascript_builtin(

- Builtins::DERIVED_GET_TRAP);

- trap = Handle<JSFunction>(JSFunction::cast(derived));

+ trap = isolate->derived_get_trap();

}

// Call trap function.

« no previous file with comments | « src/contexts.h ('k') | src/proxy.js » ('j') | no next file with comments »