Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7016011: iwyu: Include stringprintf.h where appropriate, part 3. (Closed)

Created:
9 years, 7 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
csilv
CC:
chromium-reviews, vrk (LEFT CHROMIUM), dmaclach+watch_chromium.org, annacc, ajwong+watch_chromium.org, ncarter (slow), idana, Erik does not do reviews, jam, wez+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), ddorwin+watch_chromium.org, fischman+watch_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, pam+watch_chromium.org, sergeyu+watch_chromium.org, scherkus (not reviewing), jamiewalch+watch_chromium.org, hclam+watch_chromium.org, sjl, garykac+watch_chromium.org, Aaron Boodman, acolwell GONE FROM CHROMIUM, lambroslambrou+watch_chromium.org, Paweł Hajdan Jr., jshin+watch_chromium.org
Visibility:
Public.

Description

iwyu: Include stringprintf.h where appropriate, part 3. BUG=82098 TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85088

Patch Set 1 #

Patch Set 2 : Win fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -169 lines) Patch
M base/files/file_path_watcher_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/i18n/break_iterator_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M base/metrics/stats_table_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 1 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/app_background_page_apitest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/media_uitest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/process_singleton_linux_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 6 chunks +18 lines, -16 lines 0 comments Download
M chrome/browser/sync/engine/apply_updates_command_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/engine/process_commit_response_command_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync/engine/syncapi_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/syncer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/syncable/syncable_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/features_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_helpers_unittest.cc View 3 chunks +25 lines, -23 lines 0 comments Download
M chrome/test/live_sync/live_passwords_sync_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/live_sync/live_sync_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/multiple_client_live_bookmarks_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/live_sync/multiple_client_live_preferences_sync_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/startup/feature_startup_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/startup/shutdown_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/startup/startup_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/sync/engine/mock_connection_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/v8_unit_test.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/tools/convert_dict/convert_dict_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/browser/geolocation/network_location_provider_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M courgette/adjustment_method.cc View 1 chunk +1 line, -2 lines 0 comments Download
M courgette/adjustment_method_2.cc View 1 chunk +1 line, -2 lines 0 comments Download
M jingle/notifier/listener/push_notifications_send_update_task_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/notifier/listener/push_notifications_subscribe_task_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/linux/alsa_output_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/video_frame_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M net/tools/flip_server/balsa_headers.cc View 2 chunks +2 lines, -1 line 0 comments Download
M printing/page_overlays_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/jingle_glue/iq_request_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/clipboard_util_win.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/base/l10n/l10n_util.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
James Hawkins
9 years, 7 months ago (2011-05-12 00:26:17 UTC) #1
csilv
9 years, 7 months ago (2011-05-12 00:49:55 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698