Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/renderer/safe_browsing/features_unittest.cc

Issue 7016011: iwyu: Include stringprintf.h where appropriate, part 3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/safe_browsing/features.h" 5 #include "chrome/renderer/safe_browsing/features.h"
6 6
7 #include "base/format_macros.h" 7 #include "base/format_macros.h"
8 #include "base/string_util.h" 8 #include "base/stringprintf.h"
9 #include "testing/gmock/include/gmock/gmock.h" 9 #include "testing/gmock/include/gmock/gmock.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace safe_browsing { 12 namespace safe_browsing {
13 13
14 TEST(PhishingFeaturesTest, TooManyFeatures) { 14 TEST(PhishingFeaturesTest, TooManyFeatures) {
15 FeatureMap features; 15 FeatureMap features;
16 for (size_t i = 0; i < FeatureMap::kMaxFeatureMapSize; ++i) { 16 for (size_t i = 0; i < FeatureMap::kMaxFeatureMapSize; ++i) {
17 EXPECT_TRUE(features.AddBooleanFeature(StringPrintf("Feature%" PRIuS, i))); 17 EXPECT_TRUE(features.AddBooleanFeature(
18 base::StringPrintf("Feature%" PRIuS, i)));
18 } 19 }
19 EXPECT_EQ(FeatureMap::kMaxFeatureMapSize, features.features().size()); 20 EXPECT_EQ(FeatureMap::kMaxFeatureMapSize, features.features().size());
20 21
21 // Attempting to add more features should fail. 22 // Attempting to add more features should fail.
22 for (size_t i = 0; i < 3; ++i) { 23 for (size_t i = 0; i < 3; ++i) {
23 EXPECT_FALSE(features.AddBooleanFeature(StringPrintf("Extra%" PRIuS, i))); 24 EXPECT_FALSE(features.AddBooleanFeature(
25 base::StringPrintf("Extra%" PRIuS, i)));
24 } 26 }
25 EXPECT_EQ(FeatureMap::kMaxFeatureMapSize, features.features().size()); 27 EXPECT_EQ(FeatureMap::kMaxFeatureMapSize, features.features().size());
26 } 28 }
27 29
28 TEST(PhishingFeaturesTest, IllegalFeatureValue) { 30 TEST(PhishingFeaturesTest, IllegalFeatureValue) {
29 FeatureMap features; 31 FeatureMap features;
30 EXPECT_FALSE(features.AddRealFeature("toosmall", -0.1)); 32 EXPECT_FALSE(features.AddRealFeature("toosmall", -0.1));
31 EXPECT_TRUE(features.AddRealFeature("zero", 0.0)); 33 EXPECT_TRUE(features.AddRealFeature("zero", 0.0));
32 EXPECT_TRUE(features.AddRealFeature("pointfive", 0.5)); 34 EXPECT_TRUE(features.AddRealFeature("pointfive", 0.5));
33 EXPECT_TRUE(features.AddRealFeature("one", 1.0)); 35 EXPECT_TRUE(features.AddRealFeature("one", 1.0));
34 EXPECT_FALSE(features.AddRealFeature("toolarge", 1.1)); 36 EXPECT_FALSE(features.AddRealFeature("toolarge", 1.1));
35 37
36 FeatureMap expected_features; 38 FeatureMap expected_features;
37 expected_features.AddRealFeature("zero", 0.0); 39 expected_features.AddRealFeature("zero", 0.0);
38 expected_features.AddRealFeature("pointfive", 0.5); 40 expected_features.AddRealFeature("pointfive", 0.5);
39 expected_features.AddRealFeature("one", 1.0); 41 expected_features.AddRealFeature("one", 1.0);
40 EXPECT_THAT(features.features(), 42 EXPECT_THAT(features.features(),
41 ::testing::ContainerEq(expected_features.features())); 43 ::testing::ContainerEq(expected_features.features()));
42 } 44 }
43 45
44 } // namespace safe_browsing 46 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc ('k') | chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698