Don't show suggestions in the Omnibox from the Extension App provider unless the app has Incognit...

chrome/browser/autocomplete/extension_app_provider.cc

Index: chrome/browser/autocomplete/extension_app_provider.cc
===================================================================
--- chrome/browser/autocomplete/extension_app_provider.cc	(revision 84698)
+++ chrome/browser/autocomplete/extension_app_provider.cc	(working copy)
@@ -95,6 +95,14 @@
   for (ExtensionList::const_iterator app = extensions->begin();
        app != extensions->end(); ++app) {
     if ((*app)->is_app() && (*app)->GetFullLaunchURL().is_valid()) {
+      // Incognito extensions must have incognito enabled and split mode set

[Matt Perry, 2011/05/11 23:55:27]

I think we might want to apply this to packaged apps only. I've updated the bug
asking for clarification.

We'll have to make this check in other places to actually prevent packaged apps
from loading in incognito. Given that, can you move the check to
ExtensionService::CanLoadInIncognito() or something like that?

+      // to show up in the omnibox as a suggestion.
+      if (profile_->IsOffTheRecord() &&
+          (!profile_->GetExtensionService()->
+               IsIncognitoEnabled((*app)->id()) ||
+           !(*app)->incognito_split_mode()))
+        continue;
+
       extension_apps_.push_back(
           std::make_pair((*app)->name(),
                          (*app)->GetFullLaunchURL().spec()));