Don't show suggestions in the Omnibox from the Extension App provider unless the app has Incognit...

chrome/browser/autocomplete/extension_app_provider.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/extension_app_provider.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/string16.h"
@@ skipping 77 matching lines @@
 
 void ExtensionAppProvider::RefreshAppList() {
   ExtensionService* extension_service = profile_->GetExtensionService();
   if (!extension_service)
     return;  // During testing, there is no extension service.
   const ExtensionList* extensions = extension_service->extensions();
   extension_apps_.clear();
   for (ExtensionList::const_iterator app = extensions->begin();
        app != extensions->end(); ++app) {
     if ((*app)->is_app() && (*app)->GetFullLaunchURL().is_valid()) {
+      // Incognito extensions must have incognito enabled and split mode set

[Matt Perry, 2011/05/11 23:55:27]

I think we might want to apply this to packaged apps only. I've updated the bug
asking for clarification.

We'll have to make this check in other places to actually prevent packaged apps
from loading in incognito. Given that, can you move the check to
ExtensionService::CanLoadInIncognito() or something like that?

+      // to show up in the omnibox as a suggestion.
+      if (profile_->IsOffTheRecord() &&
+          (!profile_->GetExtensionService()->
+               IsIncognitoEnabled((*app)->id()) ||
+           !(*app)->incognito_split_mode()))
+        continue;
+
       extension_apps_.push_back(
           std::make_pair((*app)->name(),
                          (*app)->GetFullLaunchURL().spec()));
     }
   }
 }
 
 void ExtensionAppProvider::RegisterForNotifications() {
   registrar_.Add(this, NotificationType::EXTENSION_LOADED,
                  NotificationService::AllSources());
@@ skipping 56 matching lines @@
     history::URLRow info;
     url_db->GetRowForURL(url, &info);
     type_count_boost =
         400 * (1.0 - (std::pow(static_cast<double>(2), -info.typed_count())));
   }
   int relevance = 575 + static_cast<int>(type_count_boost) +
                         static_cast<int>(fraction_boost);
   DCHECK_LE(relevance, kMaxRelevance);
   return relevance;
 }