Don't show suggestions in the Omnibox from the Extension App provider unless the app has Incognit...

Don't show suggestions in the Omnibox (from the Extension App provider) for packaged apps unless the app has Incognito enabled and split mode set to true. Hosted apps should always be able to load in incognito.

BUG=81304
TEST=Install a packaged app from the web store and type its name into the Omnibox of an incognito window. Make sure it does not show up. Now go to chrome://extensions and check 'Allow in incognito' for this extension. Make sure it now shows up in the Omnibox as a suggestion.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85209

[Matt Perry, 2011-05-11 23:55:26]

http://codereview.chromium.org/7016005/diff/1/chrome/browser/autocomplete/ext...
File chrome/browser/autocomplete/extension_app_provider.cc (right):

http://codereview.chromium.org/7016005/diff/1/chrome/browser/autocomplete/ext...
chrome/browser/autocomplete/extension_app_provider.cc:98: // Incognito
extensions must have incognito enabled and split mode set
I think we might want to apply this to packaged apps only. I've updated the bug
asking for clarification.

We'll have to make this check in other places to actually prevent packaged apps
from loading in incognito. Given that, can you move the check to
ExtensionService::CanLoadInIncognito() or something like that?

[Finnur, 2011-05-12 20:00:44]

Done. Please take another look.

On 2011/05/11 23:55:26, Matt Perry wrote:
>
http://codereview.chromium.org/7016005/diff/1/chrome/browser/autocomplete/ext...
> File chrome/browser/autocomplete/extension_app_provider.cc (right):
> 
>
http://codereview.chromium.org/7016005/diff/1/chrome/browser/autocomplete/ext...
> chrome/browser/autocomplete/extension_app_provider.cc:98: // Incognito
> extensions must have incognito enabled and split mode set
> I think we might want to apply this to packaged apps only. I've updated the
bug
> asking for clarification.
> 
> We'll have to make this check in other places to actually prevent packaged
apps
> from loading in incognito. Given that, can you move the check to
> ExtensionService::CanLoadInIncognito() or something like that?

[Matt Perry, 2011-05-12 20:29:15]

LGTM