Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 7013014: Added release build assert on attempt to create a RunnableFunction for a function pointer with ad... (Closed)

Created:
9 years, 7 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Added release build assert on attempt to create a RunnableFunction for a function pointer with address 1. This is actually happening. See http://crbug.com/81449. The generated code to invoke the callback puts the address of the function in the EAX register before doing CALL EAX. I see 0x00000001 in the EAX register when it crashes in the reported minidumps. I'll revert this after the next Canary. TEST=run locally and verify no assertion BUG=81449 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M base/task.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
apatrick_chromium
9 years, 7 months ago (2011-05-12 00:35:59 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
9 years, 7 months ago (2011-05-14 00:51:28 UTC) #2
cpu_(ooo_6.6-7.5)
9 years, 7 months ago (2011-05-14 00:54:55 UTC) #3
make sure to remove this before this code gets merged into m13.


On 2011/05/14 00:51:28, cpu wrote:
> lgtm

Powered by Google App Engine
This is Rietveld 408576698