base/task.h - Issue 7013014: Added release build assert on attempt to create a RunnableFunction for a function pointer with ad...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task.h

Issue 7013014: Added release build assert on attempt to create a RunnableFunction for a function pointer with ad... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/task.h

===================================================================

--- base/task.h (revision 85016)

+++ base/task.h (working copy)

@@ -449,6 +449,12 @@

COMPILE_ASSERT(

(base::internal::ParamsUseScopedRefptrCorrectly<Params>::value),

badrunnablefunctionparams);

+#if defined(OS_WIN)

+ // TODO(apatrick): Remove this ASAP. I think somewhere in the code we're

+ // posting a task to call a function pointer with this value. Step 1 is

+ // to find the site it is posted from. http://crbug.com/81449.

+ CHECK(reinterpret_cast<int>(function) != 0x00000001);

+#endif

}

~RunnableFunction() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »