Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 7009002: Fix debug crash caused by NetworkChangeNotifierChromeos. (Closed)

Created:
9 years, 6 months ago by rhashimoto
Modified:
9 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, zel
Visibility:
Public.

Description

Fix debug crash caused by NetworkChangeNotifierChromeos. - Convert NetworkChangeNotifier::NotifyObserversOfOnlineStateChange() to static. - Remove ScopedRunnableMethodFactory member from NetworkChangeNotifierChromeos. The problem is that ScopedRunnableMethodFactory is not thread-safe, so tasks created by it can only be posted to the current thread. BUG=chromium-os:16197 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88346

Patch Set 1 #

Patch Set 2 : Change NotifyObserversOfOnlineStateChange call to static. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M chrome/browser/chromeos/net/network_change_notifier_chromeos.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/net/network_change_notifier_chromeos.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/base/network_change_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/network_change_notifier.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/base/network_change_notifier_mac.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rhashimoto
9 years, 6 months ago (2011-06-06 21:20:01 UTC) #1
oshima
On 2011/06/06 21:20:01, rhashimoto wrote: looks correct to me, but you should have one of ...
9 years, 6 months ago (2011-06-06 21:38:22 UTC) #2
rhashimoto
+adamk as reviewer
9 years, 6 months ago (2011-06-06 21:43:04 UTC) #3
adamk
Looks good to me, but Will is probably a better reviewer than me (he also ...
9 years, 6 months ago (2011-06-06 21:46:58 UTC) #4
rhashimoto
Hi Will - Could you please look over this crash fix? Thanks, Roy
9 years, 6 months ago (2011-06-07 21:53:05 UTC) #5
willchan no longer on Chromium
LGTM
9 years, 6 months ago (2011-06-08 13:26:32 UTC) #6
commit-bot: I haz the power
9 years, 6 months ago (2011-06-08 16:42:14 UTC) #7
Change committed as 88346

Powered by Google App Engine
This is Rietveld 408576698