chrome/browser/chromeos/net/network_change_notifier_chromeos.cc - Issue 7009002: Fix debug crash caused by NetworkChangeNotifierChromeos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_change_notifier_chromeos.cc

Issue 7009002: Fix debug crash caused by NetworkChangeNotifierChromeos. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change NotifyObserversOfOnlineStateChange call to static. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/net/network_change_notifier_chromeos.cc

diff --git a/chrome/browser/chromeos/net/network_change_notifier_chromeos.cc b/chrome/browser/chromeos/net/network_change_notifier_chromeos.cc

index afbc17dd3ac8818d9ff03a0fd654d16b866a05cd..b8c1dc9bd80b0c76ccf5b5e4af96a4ebc2dc8ad0 100644

--- a/chrome/browser/chromeos/net/network_change_notifier_chromeos.cc

+++ b/chrome/browser/chromeos/net/network_change_notifier_chromeos.cc

@@ -12,8 +12,7 @@ namespace chromeos {

NetworkChangeNotifierChromeos::NetworkChangeNotifierChromeos()

: has_active_network_(false),

- connection_state_(chromeos::STATE_UNKNOWN),

- ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)) {

+ connection_state_(chromeos::STATE_UNKNOWN) {

chromeos::NetworkLibrary* lib =

chromeos::CrosLibrary::Get()->GetNetworkLibrary();

@@ -110,7 +109,7 @@ void NetworkChangeNotifierChromeos::OnNetworkChanged(

if (is_online != was_online || is_portal != was_portal) {

BrowserThread::PostTask(

BrowserThread::IO, FROM_HERE,

- method_factory_.NewRunnableMethod(

+ NewRunnableFunction(

&NetworkChangeNotifierChromeos::NotifyObserversOfOnlineStateChange));

}

connection_state_ = new_connection_state;