Issue 7008005: base/i18n: Pass |str| as const reference in BreakIterator::Init().

Issue 7008005: base/i18n: Pass |str| as const reference in BreakIterator::Init(). (Closed)

Created:
9 years, 7 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Tom Sepez, Evan Martin

CC:
chromium-reviews, Paweł Hajdan Jr., jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base/i18n: Pass |str| as const reference in BreakIterator::Init(). BUG=None TEST=out/Debug/base_unittests --gtest_filter=BreakIteratorTest.* R=tsepez@chromium.org,evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86689

Patch Set 3 : const reference #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -28 lines)			Patch
M	base/i18n/break_iterator.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/i18n/break_iterator.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	base/i18n/break_iterator_unittest.cc	View		14 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/history/in_memory_url_index.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/query_parser.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/download/download_item_view.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/text/text_elider.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/controls/textfield/textfield_views_model.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/view_text_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

Maybe find the original author of this code and ask them why they were using ...

9 years, 7 months ago (2011-05-25 01:40:14 UTC) #2

tfarina

On 2011/05/25 01:40:14, Evan Martin wrote: > Maybe find the original author of this code ...

9 years, 7 months ago (2011-05-25 14:43:01 UTC) #3

tfarina

http://codereview.chromium.org/7008005/diff/3001/base/i18n/break_iterator.cc File base/i18n/break_iterator.cc (right): http://codereview.chromium.org/7008005/diff/3001/base/i18n/break_iterator.cc#newcode19 base/i18n/break_iterator.cc:19: string_(str), On 2011/05/25 01:40:14, Evan Martin wrote: > Because ...

9 years, 7 months ago (2011-05-25 14:45:41 UTC) #4

tfarina

On 2011/05/25 17:04:11, Tom Sepez wrote: > LGTM. Evan, can I get your owner's lgtm ...

9 years, 7 months ago (2011-05-25 19:45:09 UTC) #6

LGTM

Expand Messages | Collapse Messages