Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3288)

Unified Diff: base/i18n/break_iterator.h

Issue 7008005: base/i18n: Pass |str| as const reference in BreakIterator::Init(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: const reference Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/i18n/break_iterator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/i18n/break_iterator.h
diff --git a/base/i18n/break_iterator.h b/base/i18n/break_iterator.h
index acd5c304986649ee9e480c8617fa509f70455217..82e8092632c94eae1e60c9848f38aa16e7cc8559 100644
--- a/base/i18n/break_iterator.h
+++ b/base/i18n/break_iterator.h
@@ -67,7 +67,7 @@ class BreakIterator {
};
// Requires |str| to live as long as the BreakIterator does.
- BreakIterator(const string16* str, BreakType break_type);
+ BreakIterator(const string16& str, BreakType break_type);
~BreakIterator();
// Init() must be called before any of the iterators are valid.
@@ -106,7 +106,7 @@ class BreakIterator {
void* iter_;
// The string we're iterating over.
- const string16* string_;
+ const string16& string_;
// The breaking style (word/space/newline).
BreakType break_type_;
« no previous file with comments | « no previous file | base/i18n/break_iterator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698