Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Issue 7006022: Revert 87415 - Convert more interfaces to the new thunk system. This goes up to and including (Closed)

Created:
9 years, 6 months ago by Lei Zhang
Modified:
9 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 87415 - Convert more interfaces to the new thunk system. This goes up to and including the ones starting with "F". Since this adds a lot more interfaces, I added the macro stuff we used for the old system to generate the various template specializations. This involded a lot of renaming since the As* needs to match the name (I was previously leaving off the "PPB_" part). I did other misc cleanup to the infrastructure. Review URL: http://codereview.chromium.org/7082036 TBR=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1203 lines, -1849 lines) Patch
M ppapi/ppapi_shared.gypi View 2 chunks +0 lines, -17 lines 0 comments Download
D ppapi/proxy/enter_proxy.h View 1 chunk +0 lines, -58 lines 0 comments Download
M ppapi/proxy/interface_id.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/plugin_resource_tracker.h View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ppapi/proxy/ppb_audio_config_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M ppapi/proxy/ppb_broker_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_buffer_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_char_set_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_char_set_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_cursor_control_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_cursor_control_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_file_chooser_proxy.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_file_chooser_proxy.cc View 6 chunks +78 lines, -69 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.cc View 10 chunks +168 lines, -123 lines 0 comments Download
M ppapi/proxy/ppb_file_system_proxy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_file_system_proxy.cc View 6 chunks +74 lines, -76 lines 0 comments Download
M ppapi/proxy/ppb_font_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_font_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_graphics_2d_proxy.h View 3 chunks +55 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_graphics_2d_proxy.cc View 8 chunks +25 lines, -82 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 2 chunks +1 line, -10 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 4 chunks +15 lines, -35 lines 0 comments Download
M ppapi/shared_impl/audio_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/audio_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/function_group_base.h View 1 chunk +35 lines, -31 lines 0 comments Download
D ppapi/shared_impl/function_group_base.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M ppapi/shared_impl/resource_object_base.h View 1 chunk +49 lines, -41 lines 0 comments Download
D ppapi/shared_impl/resource_object_base.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M ppapi/shared_impl/tracker_base.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/thunk/enter.h View 2 chunks +0 lines, -16 lines 0 comments Download
D ppapi/thunk/ppb_directory_reader_api.h View 1 chunk +0 lines, -22 lines 0 comments Download
D ppapi/thunk/ppb_directory_reader_thunk.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D ppapi/thunk/ppb_file_chooser_api.h View 1 chunk +0 lines, -22 lines 0 comments Download
D ppapi/thunk/ppb_file_chooser_thunk.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D ppapi/thunk/ppb_file_io_api.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ppapi/thunk/ppb_file_io_thunk.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D ppapi/thunk/ppb_file_io_trusted_thunk.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D ppapi/thunk/ppb_file_ref_api.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ppapi/thunk/ppb_file_ref_thunk.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D ppapi/thunk/ppb_file_system_api.h View 1 chunk +0 lines, -23 lines 0 comments Download
D ppapi/thunk/ppb_file_system_thunk.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D ppapi/thunk/ppb_find_api.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ppapi/thunk/ppb_find_thunk.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 2 chunks +0 lines, -11 lines 0 comments Download
M ppapi/thunk/thunk.h View 2 chunks +0 lines, -14 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 2 chunks +33 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_impl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppb_broker_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_broker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_buffer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_buffer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_char_set_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_char_set_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_cursor_control_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_cursor_control_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_directory_reader_impl.h View 2 chunks +8 lines, -13 lines 0 comments Download
M webkit/plugins/ppapi/ppb_directory_reader_impl.cc View 8 chunks +37 lines, -22 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_chooser_impl.h View 3 chunks +7 lines, -11 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_chooser_impl.cc View 5 chunks +53 lines, -22 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_io_impl.h View 2 chunks +39 lines, -33 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_io_impl.cc View 3 chunks +163 lines, -19 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.h View 4 chunks +14 lines, -26 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.cc View 6 chunks +213 lines, -122 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_system_impl.h View 2 chunks +8 lines, -15 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_system_impl.cc View 2 chunks +58 lines, -34 lines 0 comments Download
D webkit/plugins/ppapi/ppb_find_impl.h View 1 chunk +0 lines, -46 lines 0 comments Download
D webkit/plugins/ppapi/ppb_find_impl.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M webkit/plugins/ppapi/ppb_font_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_font_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_2d_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_2d_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_image_data_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_image_data_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 2 chunks +1 line, -10 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 3 chunks +1 line, -32 lines 0 comments Download
M webkit/plugins/ppapi/resource_tracker.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/resource_tracker.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
9 years, 6 months ago (2011-06-01 05:50:44 UTC) #1
Lei Zhang
9 years, 6 months ago (2011-06-01 05:53:26 UTC) #2
Broke PDFBrowserTest.

Powered by Google App Engine
This is Rietveld 408576698