Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: webkit/plugins/ppapi/ppb_file_chooser_impl.h

Issue 7006022: Revert 87415 - Convert more interfaces to the new thunk system. This goes up to and including (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/ppb_directory_reader_impl.cc ('k') | webkit/plugins/ppapi/ppb_file_chooser_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppb_file_chooser_impl.h
===================================================================
--- webkit/plugins/ppapi/ppb_file_chooser_impl.h (revision 87436)
+++ webkit/plugins/ppapi/ppb_file_chooser_impl.h (working copy)
@@ -10,7 +10,6 @@
#include "base/memory/ref_counted.h"
#include "ppapi/c/dev/ppb_file_chooser_dev.h"
-#include "ppapi/thunk/ppb_file_chooser_api.h"
#include "webkit/plugins/ppapi/resource.h"
struct PP_CompletionCallback;
@@ -22,22 +21,19 @@
class PPB_FileRef_Impl;
class TrackedCompletionCallback;
-class PPB_FileChooser_Impl : public Resource,
- public ::ppapi::thunk::PPB_FileChooser_API {
+class PPB_FileChooser_Impl : public Resource {
public:
PPB_FileChooser_Impl(PluginInstance* instance,
const PP_FileChooserOptions_Dev* options);
virtual ~PPB_FileChooser_Impl();
- static PP_Resource Create(PP_Instance instance,
- const PP_FileChooserOptions_Dev* options);
+ // Returns a pointer to the interface implementing PPB_FileChooser that is
+ // exposed to the plugin.
+ static const PPB_FileChooser_Dev* GetInterface();
// Resource overrides.
virtual PPB_FileChooser_Impl* AsPPB_FileChooser_Impl();
- // ResourceObjectBase overrides.
- virtual ::ppapi::thunk::PPB_FileChooser_API* AsPPB_FileChooser_API() OVERRIDE;
-
// Stores the list of selected files.
void StoreChosenFiles(const std::vector<std::string>& files);
@@ -52,9 +48,9 @@
void RunCallback(int32_t result);
- // PPB_FileChooser_API implementation.
- virtual int32_t Show(PP_CompletionCallback callback) OVERRIDE;
- virtual PP_Resource GetNextChosenFile() OVERRIDE;
+ // PPB_FileChooser implementation.
+ int32_t Show(const PP_CompletionCallback& callback);
+ scoped_refptr<PPB_FileRef_Impl> GetNextChosenFile();
private:
PP_FileChooserMode_Dev mode_;
« no previous file with comments | « webkit/plugins/ppapi/ppb_directory_reader_impl.cc ('k') | webkit/plugins/ppapi/ppb_file_chooser_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698