Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5468)

Unified Diff: chrome/installer/util/chrome_browser_operations.cc

Issue 7005019: Put SxS switches back into the rename command. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/chrome_browser_operations.cc
===================================================================
--- chrome/installer/util/chrome_browser_operations.cc (revision 84779)
+++ chrome/installer/util/chrome_browser_operations.cc (working copy)
@@ -50,18 +50,33 @@
std::vector<FilePath>* com_dll_list) const {
}
-void ChromeBrowserOperations::AppendProductFlags(
+void ChromeBrowserOperations::AppendUninstallFlags(
const std::set<std::wstring>& options,
- CommandLine* uninstall_command) const {
- DCHECK(uninstall_command);
+ CommandLine* cmd_line) const {
+ DCHECK(cmd_line);
if (options.find(kOptionMultiInstall) != options.end()) {
- if (!uninstall_command->HasSwitch(switches::kMultiInstall))
- uninstall_command->AppendSwitch(switches::kMultiInstall);
- uninstall_command->AppendSwitch(switches::kChrome);
+ // Add --multi-install if it isn't already there.
+ if (!cmd_line->HasSwitch(switches::kMultiInstall))
+ cmd_line->AppendSwitch(switches::kMultiInstall);
+
+ // --chrome is only needed in multi-install.
+ cmd_line->AppendSwitch(switches::kChrome);
}
}
+void ChromeBrowserOperations::AppendRenameFlags(
+ const std::set<std::wstring>& options,
+ CommandLine* cmd_line) const {
+ DCHECK(cmd_line);
+
+ // Add --multi-install if it isn't already there.
+ if (options.find(kOptionMultiInstall) != options.end() &&
+ !cmd_line->HasSwitch(switches::kMultiInstall)) {
+ cmd_line->AppendSwitch(switches::kMultiInstall);
+ }
+}
+
bool ChromeBrowserOperations::SetChannelFlags(
const std::set<std::wstring>& options,
bool set,
« no previous file with comments | « chrome/installer/util/chrome_browser_operations.h ('k') | chrome/installer/util/chrome_browser_sxs_operations.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698