Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: chrome/installer/util/chrome_browser_operations.cc

Issue 7005019: Put SxS switches back into the rename command. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/util/chrome_browser_operations.h" 5 #include "chrome/installer/util/chrome_browser_operations.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/file_path.h" 8 #include "base/file_path.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "chrome/installer/util/browser_distribution.h" 10 #include "chrome/installer/util/browser_distribution.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 std::vector<FilePath>* key_files) const { 43 std::vector<FilePath>* key_files) const {
44 DCHECK(key_files); 44 DCHECK(key_files);
45 key_files->push_back(FilePath(installer::kChromeDll)); 45 key_files->push_back(FilePath(installer::kChromeDll));
46 } 46 }
47 47
48 void ChromeBrowserOperations::AddComDllList( 48 void ChromeBrowserOperations::AddComDllList(
49 const std::set<std::wstring>& options, 49 const std::set<std::wstring>& options,
50 std::vector<FilePath>* com_dll_list) const { 50 std::vector<FilePath>* com_dll_list) const {
51 } 51 }
52 52
53 void ChromeBrowserOperations::AppendProductFlags( 53 void ChromeBrowserOperations::AppendUninstallFlags(
54 const std::set<std::wstring>& options, 54 const std::set<std::wstring>& options,
55 CommandLine* uninstall_command) const { 55 CommandLine* cmd_line) const {
56 DCHECK(uninstall_command); 56 DCHECK(cmd_line);
57 57
58 if (options.find(kOptionMultiInstall) != options.end()) { 58 if (options.find(kOptionMultiInstall) != options.end()) {
59 if (!uninstall_command->HasSwitch(switches::kMultiInstall)) 59 // Add --multi-install if it isn't already there.
60 uninstall_command->AppendSwitch(switches::kMultiInstall); 60 if (!cmd_line->HasSwitch(switches::kMultiInstall))
61 uninstall_command->AppendSwitch(switches::kChrome); 61 cmd_line->AppendSwitch(switches::kMultiInstall);
62
63 // --chrome is only needed in multi-install.
64 cmd_line->AppendSwitch(switches::kChrome);
65 }
66 }
67
68 void ChromeBrowserOperations::AppendRenameFlags(
69 const std::set<std::wstring>& options,
70 CommandLine* cmd_line) const {
71 DCHECK(cmd_line);
72
73 // Add --multi-install if it isn't already there.
74 if (options.find(kOptionMultiInstall) != options.end() &&
75 !cmd_line->HasSwitch(switches::kMultiInstall)) {
76 cmd_line->AppendSwitch(switches::kMultiInstall);
62 } 77 }
63 } 78 }
64 79
65 bool ChromeBrowserOperations::SetChannelFlags( 80 bool ChromeBrowserOperations::SetChannelFlags(
66 const std::set<std::wstring>& options, 81 const std::set<std::wstring>& options,
67 bool set, 82 bool set,
68 ChannelInfo* channel_info) const { 83 ChannelInfo* channel_info) const {
69 #if defined(GOOGLE_CHROME_BUILD) 84 #if defined(GOOGLE_CHROME_BUILD)
70 DCHECK(channel_info); 85 DCHECK(channel_info);
71 return channel_info->SetChrome(set); 86 return channel_info->SetChrome(set);
72 #else 87 #else
73 return false; 88 return false;
74 #endif 89 #endif
75 } 90 }
76 91
77 bool ChromeBrowserOperations::ShouldCreateUninstallEntry( 92 bool ChromeBrowserOperations::ShouldCreateUninstallEntry(
78 const std::set<std::wstring>& options) const { 93 const std::set<std::wstring>& options) const {
79 return true; 94 return true;
80 } 95 }
81 96
82 } // namespace installer 97 } // namespace installer
OLDNEW
« no previous file with comments | « chrome/installer/util/chrome_browser_operations.h ('k') | chrome/installer/util/chrome_browser_sxs_operations.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698