Put SxS switches back into the rename command.

Put SxS switches back into the rename command.

BUG=82207
TEST=See if in-use updates in the canaries and in Chrome Frame work.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85108

[grt (UTC plus 2), 2011-05-11 03:21:42]

I think this brings back the right behavior for Chrome SxS and Chrome Frame. 
I'll do some manual testing tomorrow to be sure, and consider what could be
added to the validator and/or tests to catch future regressions.

[robertshield, 2011-05-11 18:45:04]

lg, nits:

http://codereview.chromium.org/7005019/diff/4/chrome/installer/util/chrome_br...
File chrome/installer/util/chrome_browser_operations.cc (right):

http://codereview.chromium.org/7005019/diff/4/chrome/installer/util/chrome_br...
chrome/installer/util/chrome_browser_operations.cc:60: // Add --multi-install if
it isn't already there for all purposes.
drop "for all purposes"

http://codereview.chromium.org/7005019/diff/4/chrome/installer/util/chrome_fr...
File chrome/installer/util/chrome_frame_operations.cc (right):

http://codereview.chromium.org/7005019/diff/4/chrome/installer/util/chrome_fr...
chrome/installer/util/chrome_frame_operations.cc:116: if (!is_multi_install)
Consider moving this code to a COMMAND_RENAME_SETUP case, falling through from
the COMMAND_UNINSTALL case with a NOTREACHED() in the default clause.

http://codereview.chromium.org/7005019/diff/8001/chrome/installer/util/chrome...
File chrome/installer/util/chrome_browser_operations.cc (right):

http://codereview.chromium.org/7005019/diff/8001/chrome/installer/util/chrome...
chrome/installer/util/chrome_browser_operations.cc:55: CommandPurpose purpose,
Consider having separate methods for AppendUninstallFlags and AppendRenameFlags.
This would remove the need to DCHECK on enum values and would make each method
simpler in several cases.

[grt (UTC plus 2), 2011-05-11 20:09:12]

PTAL.

http://codereview.chromium.org/7005019/diff/4/chrome/installer/util/chrome_br...
File chrome/installer/util/chrome_browser_operations.cc (right):

http://codereview.chromium.org/7005019/diff/4/chrome/installer/util/chrome_br...
chrome/installer/util/chrome_browser_operations.cc:60: // Add --multi-install if
it isn't already there for all purposes.
On 2011/05/11 18:45:04, robertshield wrote:
> drop "for all purposes"

Done.

http://codereview.chromium.org/7005019/diff/8001/chrome/installer/util/chrome...
chrome/installer/util/chrome_browser_operations.cc:55: CommandPurpose purpose,
On 2011/05/11 18:45:04, robertshield wrote:
> Consider having separate methods for AppendUninstallFlags and
AppendRenameFlags.
> This would remove the need to DCHECK on enum values and would make each method
> simpler in several cases.

Done.

[robertshield, 2011-05-11 20:16:40]

LGTM

[commit-bot: I haz the power, 2011-05-12 03:14:51]

Try job failure for 7005019-14002 on win:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2011-05-12 06:59:55]

Change committed as 85108