Issue 7003070: Fix bug 84783: BlobURLRequestJobTest uses URLRequest::job()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7003070: Fix bug 84783: BlobURLRequestJobTest uses URLRequest::job() (Closed)

Created:
9 years, 6 months ago by jianli

Modified:
9 years, 6 months ago

Reviewers:
wtc

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix bug 84783: BlobURLRequestJobTest uses URLRequest::job() BUG=84783 TEST=existing tests since no new feature Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88446

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	webkit/blob/blob_url_request_job_unittest.cc	View		1 chunk	+1 line, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/7003070/diff/1/webkit/blob/blob_url_request_job_unittest.cc File webkit/blob/blob_url_request_job_unittest.cc (right): http://codereview.chromium.org/7003070/diff/1/webkit/blob/blob_url_request_job_unittest.cc#newcode72 webkit/blob/blob_url_request_job_unittest.cc:72: if (!request->is_pending()) { I wonder if we should ...

9 years, 6 months ago (2011-06-08 22:16:20 UTC) #2

jianli

9 years, 6 months ago (2011-06-08 22:36:22 UTC) #3

On Wed, Jun 8, 2011 at 3:16 PM, <wtc@chromium.org> wrote:

> LGTM.
>
>
> http://codereview.chromium.**org/7003070/diff/1/webkit/**
>
blob/blob_url_request_job_**unittest.cc<http://codereview.chromium.org/7003070/diff/1/webkit/blob/blob_url_request_job_unittest.cc>
> File webkit/blob/blob_url_request_**job_unittest.cc (right):
>
> http://codereview.chromium.**org/7003070/diff/1/webkit/**
>
blob/blob_url_request_job_**unittest.cc#newcode72<http://codereview.chromium.org/7003070/diff/1/webkit/blob/blob_url_request_job_unittest.cc#newcode72>
> webkit/blob/blob_url_request_**job_unittest.cc:72: if
> (!request->is_pending()) {
> I wonder if we should test !request->status().is_io_**pending()
> instead.  See lines 79-81 below.


I can't do this because URLRequest::Read has not been called at that time
and thus URLRequestStatus.status is still set to the initialized
value SUCCESS, not IO_PENDING.

>
>
>
http://codereview.chromium.**org/7003070/<http://codereview.chromium.org/7003...
>

Expand Messages | Collapse Messages