Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webkit/blob/blob_url_request_job_unittest.cc

Issue 7003070: Fix bug 84783: BlobURLRequestJobTest uses URLRequest::job() (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/blob/blob_url_request_job_unittest.cc
===================================================================
--- webkit/blob/blob_url_request_job_unittest.cc (revision 88385)
+++ webkit/blob/blob_url_request_job_unittest.cc (working copy)
@@ -69,9 +69,7 @@
private:
void ReadSome(net::URLRequest* request) {
- // job() is not part of the URLRequest public API so it should not be
- // used here. Bug 84783.
- if (request->job()->is_done()) {
+ if (!request->is_pending()) {
wtc 2011/06/08 22:16:20 I wonder if we should test !request->status().is_i
RequestComplete();
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698