Break into the debugger if we have a stack dump and are currently debugging.

Break into the debugger if we have a stack dump and are currently debugging.

While debugging browser tests, I noticed a few stackdumps fly by without catching them.  This code snippet breaks into the debugger only when it's being debugged.

BUG=None
TEST=kill -ABRT your process while debugging and see if you catch in the debugger.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88750

[Sheridan Rawlins, 2011-06-08 02:58:20]

Hi, here's a little improvement to be able to debug tests which get crashes by
breaking into the debugger, when running.

[brettw, 2011-06-10 05:30:08]

I'll defer to Evan on this (I'll say LGTM to make commit bot happy if Evan is).

[Evan Martin, 2011-06-10 16:39:04]

I don't really get why this doesn't happen implicitly if you're using a
debugger, but LGTM otherwise

http://codereview.chromium.org/7003049/diff/1/base/process_util_posix.cc
File base/process_util_posix.cc (right):

http://codereview.chromium.org/7003049/diff/1/base/process_util_posix.cc#newc...
base/process_util_posix.cc:109: if (debug::BeingDebugged())
Does this work?  I thought we didn't implement this function.

[Sheridan Rawlins, 2011-06-10 23:02:58]

Doesn't hit debugger because this interrupt calls exit() (and I think debugger
only catches unhandled signals.

http://codereview.chromium.org/7003049/diff/1/base/process_util_posix.cc
File base/process_util_posix.cc (right):

http://codereview.chromium.org/7003049/diff/1/base/process_util_posix.cc#newc...
base/process_util_posix.cc:109: if (debug::BeingDebugged())
It is implemented, and worked for me.

On 2011/06/10 16:39:05, Evan Martin wrote:
> Does this work?  I thought we didn't implement this function.

[commit-bot: I haz the power, 2011-06-11 00:46:11]

Change committed as 88750