Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3223)

Unified Diff: base/process_util_posix.cc

Issue 7003049: Break into the debugger if we have a stack dump and are currently debugging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util_posix.cc
diff --git a/base/process_util_posix.cc b/base/process_util_posix.cc
index 1ea90c3dd4fb844cfa9e37a6a387a0a3400a815a..287f5c786d389166bd68d1bdf2bcd6d14fa52cfc 100644
--- a/base/process_util_posix.cc
+++ b/base/process_util_posix.cc
@@ -18,6 +18,7 @@
#include "base/command_line.h"
#include "base/compiler_specific.h"
+#include "base/debug/debugger.h"
#include "base/debug/stack_trace.h"
#include "base/dir_reader_posix.h"
#include "base/eintr_wrapper.h"
@@ -105,6 +106,9 @@ int WaitpidWithTimeout(ProcessHandle handle, int64 wait_milliseconds,
}
void StackDumpSignalHandler(int signal, siginfo_t* info, ucontext_t* context) {
+ if (debug::BeingDebugged())
Evan Martin 2011/06/10 16:39:05 Does this work? I thought we didn't implement thi
Sheridan Rawlins 2011/06/10 23:02:58 It is implemented, and worked for me. On 2011/06/
+ debug::BreakDebugger();
+
LOG(ERROR) << "Received signal " << signal;
debug::StackTrace().PrintBacktrace();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698