Issue 7003046: Use NSS_DISABLE_UNLOAD in valgrind and heapcheck scripts to avoid unsymbolized backtraces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7003046: Use NSS_DISABLE_UNLOAD in valgrind and heapcheck scripts to avoid unsymbolized backtraces. (Closed)

Created:
9 years, 6 months ago by mattm

Modified:
9 years, 6 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Use NSS_DISABLE_UNLOAD in valgrind and heapcheck scripts to avoid unsymbolized backtraces. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88408

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
M	tools/heapcheck/heapcheck_test.py	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	tools/valgrind/valgrind.sh	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	tools/valgrind/valgrind_test.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/valgrind/valgrind_webkit_tests.sh	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

mattm

This isn't strictly necessary at the moment since we intentionally leak NSS and thus it ...

9 years, 6 months ago (2011-06-07 23:55:10 UTC) #1

LGTM
Thanks for taking care of this!