Issue 6998008: In r84572, I forgot to move CheckChangeSvnEolStyle() to commit-only check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6998008: In r84572, I forgot to move CheckChangeSvnEolStyle() to commit-only check. (Closed)

Created:
9 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

In r84572, I forgot to move CheckChangeSvnEolStyle() to commit-only check. This check is also handled by the commit bot so no need to harass people when uploading. R=dpranke@chromium.org BUG=none TEST=Nobody wrote a test for PanProjectChecks() and I didn't write this function, no way I won't. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84814

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	presubmit_canned_checks.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages