Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: presubmit_canned_checks.py

Issue 6998008: In r84572, I forgot to move CheckChangeSvnEolStyle() to commit-only check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index c62caf5a64b99f3c496ec8d5f22be4cf99649724..ae82d50618c3d2a5030ce6d12b7831594896fb46 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -936,9 +936,6 @@ def PanProjectChecks(input_api, output_api,
snapshot( "checking stray whitespace")
results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
input_api, output_api, source_file_filter=sources))
- snapshot("checking eol style")
- results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
- input_api, output_api, source_file_filter=text_files))
snapshot("checking nsobjects")
results.extend(_CheckConstNSObject(
input_api, output_api, source_file_filter=sources))
@@ -949,6 +946,9 @@ def PanProjectChecks(input_api, output_api,
# The following checks are only done on commit, since the commit bot will
# auto-fix most of these.
if input_api.is_committing:
+ snapshot("checking eol style")
+ results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
+ input_api, output_api, source_file_filter=text_files))
snapshot("checking svn mime types")
results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
input_api, output_api))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698