Issue 6998002: Send live resize messages to renderer

Issue 6998002: Send live resize messages to renderer (Closed)

Created:
9 years, 7 months ago by sail

Modified:
9 years, 6 months ago

Reviewers:
Robert Sesek, darin (slow to review), Avi (use Gerrit), Nico, Ben Goodger (Google)

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Send live resize messages to renderer This change sends live resize start/stop messages to the renderer. This is needed for overlay scrollbar support since we need to show overlay scrollbars on live resize start and hide them on live resize end. BUG=74057 TEST=Ran and verified that overlay scrollbars were shown during live resize. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88206

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : Updated based on WebWidget changes. #

Patch Set 5 : Fixed comment #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -1 line)			Patch
M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View	1 2 3	1 chunk	+12 lines, -0 lines	0 comments	Download
M	content/common/view_messages.h	View	1 2 3 4	2 chunks	+5 lines, -1 line	0 comments	Download
M	content/renderer/render_view.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/render_view.cc	View	1 2 3	2 chunks	+14 lines, -0 lines	0 comments	Download
M	content/renderer/render_widget_fullscreen_pepper.cc	View	1 2 3	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

sail

Note, this change depends on a WebKit change to hookup the willStartLiveResize/willEndLiveResize.

9 years, 7 months ago (2011-05-10 00:12:15 UTC) #1

sail

The webkit side of this change: https://bugs.webkit.org/show_bug.cgi?id=60518

9 years, 7 months ago (2011-05-10 00:27:03 UTC) #2

Robert Sesek

You'll also need an OWNER to sign off. http://codereview.chromium.org/6998002/diff/3002/content/common/view_messages.h File content/common/view_messages.h (right): http://codereview.chromium.org/6998002/diff/3002/content/common/view_messages.h#newcode1127 content/common/view_messages.h:1127: Maybe ...

9 years, 7 months ago (2011-05-10 14:21:24 UTC) #4

sail

Added avi from the owners file. http://codereview.chromium.org/6998002/diff/3002/content/common/view_messages.h File content/common/view_messages.h (right): http://codereview.chromium.org/6998002/diff/3002/content/common/view_messages.h#newcode1127 content/common/view_messages.h:1127: On 2011/05/10 14:21:24, ...

9 years, 7 months ago (2011-05-10 16:02:49 UTC) #5

sail

Adding a few other people from the owners file since I think Avi is out ...

9 years, 7 months ago (2011-05-10 16:10:14 UTC) #6

Nico

Lgtm On May 10, 2011 9:10 AM, <sail@chromium.org> wrote: > Adding a few other people ...

9 years, 7 months ago (2011-05-10 17:08:26 UTC) #7

Avi (use Gerrit)

http://codereview.chromium.org/6998002/diff/6001/content/common/view_messages.h File content/common/view_messages.h (right): http://codereview.chromium.org/6998002/diff/6001/content/common/view_messages.h#newcode1129 content/common/view_messages.h:1129: // ended. that the view has started or ended ...

9 years, 7 months ago (2011-05-10 23:22:55 UTC) #9

sail

9 years, 7 months ago (2011-05-13 22:14:54 UTC) #10

Addressed review comments. Waiting for webkit side of this change to be checked
in before committing.

http://codereview.chromium.org/6998002/diff/6001/content/common/view_messages.h
File content/common/view_messages.h (right):

http://codereview.chromium.org/6998002/diff/6001/content/common/view_messages...
content/common/view_messages.h:1129: // ended.
On 2011/05/10 23:22:56, Avi wrote:
> that the view has started or ended what?

Done.

Expand Messages | Collapse Messages