Hooks for out-of-process (OOP) debugger.

src/trusted/service_runtime/nacl_app_thread.c

Index: src/trusted/service_runtime/nacl_app_thread.c
===================================================================
--- src/trusted/service_runtime/nacl_app_thread.c	(revision 5621)
+++ src/trusted/service_runtime/nacl_app_thread.c	(working copy)
@@ -12,6 +12,7 @@
 #include "native_client/src/trusted/service_runtime/nacl_desc_effector_ldr.h"
 
 #include "native_client/src/trusted/service_runtime/nacl_globals.h"
+#include "native_client/src/trusted/service_runtime/nacl_oop_debugger_hooks.h"
 #include "native_client/src/trusted/service_runtime/nacl_tls.h"
 #include "native_client/src/trusted/service_runtime/nacl_switch_to_app.h"
 #include "native_client/src/trusted/service_runtime/nacl_stack_safety.h"
@@ -52,6 +53,8 @@
     natp->nap->debug_stub_callbacks->thread_create_hook(natp);
   }
 
+  NaClOopDebuggerThreadCreateHook(natp);
+
   /*
    * We need to set an exception handler in every thread we start,
    * otherwise the system's default handler is called and a message box is
@@ -142,6 +145,7 @@
   if (NULL != natp->nap->debug_stub_callbacks) {
     natp->nap->debug_stub_callbacks->thread_exit_hook(natp);

[Mark Seaborn, 2011/06/13 19:40:51]

There's already a hook facility right here.  Can't you reuse this in some way?

[garianov1, 2011/06/13 20:09:10]

My intention is to enable OOP debugger hooks all the time,
no flag is needed. At least on Windows, hooks code is short,
and seems safe to me.
Also, if we need to put these hooks under a flag, then it should be a different
flag, so that both in-process and
out-of-process debuggers can coexists (at least for now).

   }
+  NaClOopDebuggerThreadExitHook(natp, natp->nap->exit_status);
 
   NaClThreadDtor(&natp->thread);
   NaClSignalStackUnregister();