Hooks for out-of-process (OOP) debugger.

src/trusted/service_runtime/nacl_app_thread.c

 /*
  * Copyright (c) 2011 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * NaCl Server Runtime user thread state.
  */
 #include "native_client/src/shared/platform/nacl_check.h"
 #include "native_client/src/shared/platform/nacl_sync_checked.h"
 #include "native_client/src/trusted/service_runtime/nacl_desc_effector_ldr.h"
 
 #include "native_client/src/trusted/service_runtime/nacl_globals.h"
+#include "native_client/src/trusted/service_runtime/nacl_oop_debugger_hooks.h"
 #include "native_client/src/trusted/service_runtime/nacl_tls.h"
 #include "native_client/src/trusted/service_runtime/nacl_switch_to_app.h"
 #include "native_client/src/trusted/service_runtime/nacl_stack_safety.h"
 #include "native_client/src/trusted/service_runtime/nacl_syscall_common.h"
 
 
 void WINAPI NaClThreadLauncher(void *state) {
   struct NaClAppThread *natp = (struct NaClAppThread *) state;
   NaClLog(4, "NaClThreadLauncher: entered\n");
 
@@ skipping 20 matching lines @@
 
   NaClStackSafetyNowOnUntrustedStack();  /* real soon now! */
 
   /*
    * Notify the debug stub, that a new thread is availible.
    */
   if (NULL != natp->nap->debug_stub_callbacks) {
     natp->nap->debug_stub_callbacks->thread_create_hook(natp);
   }
 
+  NaClOopDebuggerThreadCreateHook(natp);
+
   /*
    * We need to set an exception handler in every thread we start,
    * otherwise the system's default handler is called and a message box is
    * shown.
    */
   WINDOWS_EXCEPTION_TRY;
   NaClStartThreadInApp(natp, natp->user.prog_ctr);
   WINDOWS_EXCEPTION_CATCH;
 }
 
@@ skipping 68 matching lines @@
 
 void NaClAppThreadDtor(struct NaClAppThread *natp) {
   /*
    * the thread must not be still running, else this crashes the system
    */
 
   /*
    * Notify the debug stub that we are done with this thread
    */
   if (NULL != natp->nap->debug_stub_callbacks) {
     natp->nap->debug_stub_callbacks->thread_exit_hook(natp);

[Mark Seaborn, 2011/06/13 19:40:51]

There's already a hook facility right here.  Can't you reuse this in some way?

[garianov1, 2011/06/13 20:09:10]

My intention is to enable OOP debugger hooks all the time,
no flag is needed. At least on Windows, hooks code is short,
and seems safe to me.
Also, if we need to put these hooks under a flag, then it should be a different
flag, so that both in-process and
out-of-process debuggers can coexists (at least for now).

   }
+  NaClOopDebuggerThreadExitHook(natp, natp->nap->exit_status);
 
   NaClThreadDtor(&natp->thread);
   NaClSignalStackUnregister();
   NaClSignalStackFree(natp->signal_stack);
   natp->signal_stack = NULL;
   NaClClosureResultDtor(&natp->result);
   NaClTlsFree(natp);
   NaClCondVarDtor(&natp->cv);
   NaClMutexDtor(&natp->mu);
 }
@@ skipping 35 matching lines @@
     return 0;
   }
 
   return NaClAppThreadCtor(natp,
                            nap,
                            usr_entry,
                            usr_stack_ptr,
                            tls_idx,
                            sys_tdb_base);
 }