New NaCl zygote implementation 2

chrome/nacl/nacl_listener.h

Index: chrome/nacl/nacl_listener.h
diff --git a/chrome/nacl/nacl_listener.h b/chrome/nacl/nacl_listener.h
new file mode 100644
index 0000000000000000000000000000000000000000..ff28ec747528472bce87a77c1a753629081fa21f
--- /dev/null
+++ b/chrome/nacl/nacl_listener.h
@@ -0,0 +1,27 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#ifndef CHROME_NACL_NACL_LISTENER_H_
+#define CHROME_NACL_NACL_LISTENER_H_
+#pragma once
+
+

[jam, 2011/06/21 20:54:08]

nit: extra line

[Brad Chen, 2011/06/21 23:43:48]

Done.

+#include "ipc/ipc_channel.h"
+#include "chrome/common/nacl_messages.h"

[jam, 2011/06/21 20:54:08]

nit: we only include messages files from cc files for both performance reasons
(there's a lot of template expansion) and also since the files don't have
include guards

[Brad Chen, 2011/06/21 23:43:48]

Done.

+
+#define kNaClListenerHandle "nacllistenerhandle"

[jam, 2011/06/21 20:54:08]

the channel name can't be hardcoded.  there are a few reasons: chrome can have
multiple browser processes running, each with a different user data dir.  you
don't want to share any processes between them.  also, if chrome crashes and
restarts, and for whatever reason this process is still running, you want the
new browser to not reuse the old process.

use ChildProcessInfo::GenerateRandomChannelID to generate the child name, and
pass the name as a command line flag (see how ChildProcessHost does it). the
child process can then get the channel name from the command line arguments.

[Brad Chen, 2011/06/21 23:43:48]

Done.

This handle is passed into the constructor for IPC::Channel but never used
again, so things seem to work if I just pass a
ChildProcessInfo::GenerateRandomChannelID() in directly to the constructor.

On 2011/06/21 20:54:08, John Abd-El-Malek wrote:

+
+class NaClListener : public IPC::Channel::Listener {
+ public:
+  NaClListener() {}
+  ~NaClListener() {}
+
+  void OnStartSelLdr(std::vector<nacl::FileDescriptor> handles,

[jam, 2011/06/21 20:54:08]

nit: the usual style is to make channel handlers private

[Brad Chen, 2011/06/21 23:43:48]

Done.

+                     bool have_irt_file);
+  virtual bool OnMessageReceived(const IPC::Message& msg);
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(NaClListener);
+};
+
+#endif  // CHROME_NACL_NACL_LISTENER_H_