chrome/nacl/nacl_listener.h - Issue 6995121: New NaCl zygote implementation 2

Side by Side Diff: chrome/nacl/nacl_listener.h

Issue 6995121: New NaCl zygote implementation 2 (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Use IPC::Channel directly instead of ChildProcess Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 #ifndef CHROME_NACL_NACL_LISTENER_H_

	5 #define CHROME_NACL_NACL_LISTENER_H_

	6 #pragma once

	7

	8
	jam 2011/06/21 20:54:08 nit: extra line nit: extra line Brad Chen 2011/06/21 23:43:48 Done. Show quoted text On 2011/06/21 20:54:08, John Abd-El-Malek wrote: > nit: extra line Done.
	9 #include "ipc/ipc_channel.h"

	10 #include "chrome/common/nacl_messages.h"
	jam 2011/06/21 20:54:08 nit: we only include messages files from cc files nit: we only include messages files from cc files for both performance reasons (there's a lot of template expansion) and also since the files don't have include guards Brad Chen 2011/06/21 23:43:48 Done. Show quoted text On 2011/06/21 20:54:08, John Abd-El-Malek wrote: > nit: we only include messages files from cc files for both performance reasons > (there's a lot of template expansion) and also since the files don't have > include guards Done.
	11

	12 #define kNaClListenerHandle "nacllistenerhandle"
	jam 2011/06/21 20:54:08 the channel name can't be hardcoded. there are a the channel name can't be hardcoded. there are a few reasons: chrome can have multiple browser processes running, each with a different user data dir. you don't want to share any processes between them. also, if chrome crashes and restarts, and for whatever reason this process is still running, you want the new browser to not reuse the old process. use ChildProcessInfo::GenerateRandomChannelID to generate the child name, and pass the name as a command line flag (see how ChildProcessHost does it). the child process can then get the channel name from the command line arguments. Brad Chen 2011/06/21 23:43:48 Done. This handle is passed into the constructor Done. This handle is passed into the constructor for IPC::Channel but never used again, so things seem to work if I just pass a ChildProcessInfo::GenerateRandomChannelID() in directly to the constructor. On 2011/06/21 20:54:08, John Abd-El-Malek wrote: Show quoted text > the channel name can't be hardcoded. there are a few reasons: chrome can have > multiple browser processes running, each with a different user data dir. you > don't want to share any processes between them. also, if chrome crashes and > restarts, and for whatever reason this process is still running, you want the > new browser to not reuse the old process. > > use ChildProcessInfo::GenerateRandomChannelID to generate the child name, and > pass the name as a command line flag (see how ChildProcessHost does it). the > child process can then get the channel name from the command line arguments.
	13

	14 class NaClListener : public IPC::Channel::Listener {

	15 public:

	16 NaClListener() {}

	17 ~NaClListener() {}

	18

	19 void OnStartSelLdr(std::vector<nacl::FileDescriptor> handles,
	jam 2011/06/21 20:54:08 nit: the usual style is to make channel handlers p nit: the usual style is to make channel handlers private Brad Chen 2011/06/21 23:43:48 Done. Show quoted text On 2011/06/21 20:54:08, John Abd-El-Malek wrote: > nit: the usual style is to make channel handlers private Done.
	20 bool have_irt_file);

	21 virtual bool OnMessageReceived(const IPC::Message& msg);

	22

	23 private:

	24 DISALLOW_COPY_AND_ASSIGN(NaClListener);

	25 };

	26

	27 #endif // CHROME_NACL_NACL_LISTENER_H_

OLD	NEW

« chrome/nacl/nacl_helper_linux.cc ('K') | « chrome/nacl/nacl_launcher_thread.cc ('k') | chrome/nacl/nacl_listener.cc » ('j') | chrome/nacl/nacl_main.cc » ('J')